From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH 00/10] drm/i915: LVDS/eDP panel,
 EDID and fixed mode refactoring
Date: Mon, 22 Oct 2012 19:37:38 +0200
Message-ID: <20121022173738.GG24005@phenom.ffwll.local>
References: <cover.1350644022.git.jani.nikula@intel.com>
	<6c3329$6r5408@orsmga002.jf.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail-wi0-f177.google.com (mail-wi0-f177.google.com
	[209.85.212.177])
	by gabe.freedesktop.org (Postfix) with ESMTP id 8EB5D9E75D
	for <intel-gfx@lists.freedesktop.org>;
	Mon, 22 Oct 2012 10:36:37 -0700 (PDT)
Received: by mail-wi0-f177.google.com with SMTP id hj13so2087311wib.12
	for <intel-gfx@lists.freedesktop.org>;
	Mon, 22 Oct 2012 10:36:36 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <6c3329$6r5408@orsmga002.jf.intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Jani Nikula <jani.nikula@intel.com>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Fri, Oct 19, 2012 at 06:58:56PM +0100, Chris Wilson wrote:
> On Fri, 19 Oct 2012 14:51:42 +0300, Jani Nikula <jani.nikula@intel.com> wrote:
> > Hi all, this is some LVDS/eDP panel refactoring and cleanup based on
> > Chris Wilson's earlier work and ideas last year [1]. I left out eDP lid
> > notifier based on Jesse's comments [2]; more of Jesse's old review is at
> > [3].
> > 
> > The main high level difference to Chris' patches is that intel_panel and
> > the cached EDID are placed in intel_connector rather than anywhere
> > else. This is because Daniel hinted that we might want to do some more
> > generic EDID caching (indeed, why keep reading the EDID if the display
> > has not been unplugged?). With the EDID and intel_panel in
> > intel_connector, we can add functions to query EDID and modes with
> > transparent caching and fallback to fixed mode when EDID is not
> > available.
> 
> Patches look really good, I haven't checked yet to see if there is
> anything missing, but I already like the improvement to the code....
> 
> So for the series,
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>

Slurped in the entire series, thanks a lot for the patches and review.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch