All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V3 2/5] ARM: enhance u-boot.lds to detect over-sized SPL
Date: Mon, 22 Oct 2012 10:52:12 -0700	[thread overview]
Message-ID: <20121022175212.GB11518@bill-the-cat> (raw)
In-Reply-To: <1350922776-30909-2-git-send-email-swarren@wwwdotorg.org>

On Mon, Oct 22, 2012 at 10:19:33AM -0600, Stephen Warren wrote:

> From: Stephen Warren <swarren@nvidia.com>
> 
> Add an ASSERT() to u-boot.lds to detect an SPL that doesn't fit within
> SPL_TEXT_BASE..SPL_MAX_SIZE.
> 
> Different .lds files implement this check in two possible ways:
> 1) An ASSERT() like this
> 2) Defining a MEMORY region of size SPL_MAX_SIZE, and re-directing all
>    linker output into that region. Since u-boot.lds is used for both
>    SPL and main U-Boot, this would entail only sometimes defining a
>    MEMORY region, and only sometimes performing that redirection, and
>    hence option (1) was deemed much simpler, and hence implemented.
> 
> Note that this causes build failures at least for NVIDIA Tegra Seaboard
> and Ventana. However, these are legitimate; the SPL doesn't fit within
> the required space, and this does cause runtime issues.
> 
> Signed-off-by: Stephen Warren <swarren@nvidia.com>
> Acked-by: Simon Glass <sjg@chromium.org>
> Acked-by: Allen Martin <amartin@nvidia.com>

This isn't quite what I envisoned at first (see 
arch/arm/cpu/armv7/omap-common/u-boot-spl.lds) but I think for the
generic linker script, this is the least instrusive method.

Acked-by: Tom Rini <trini@ti.com>

And since parts 1 and 2 are generic code, I've assigned them to Albert
in patchwork.  It's his call if he wants to take them or have them all
come via the tegra tree.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20121022/6f8eca56/attachment.pgp>

  reply	other threads:[~2012-10-22 17:52 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-22 16:19 [U-Boot] [PATCH V3 1/5] ARM: fix u-boot.lds for -ffunction-sections/-fdata-sections Stephen Warren
2012-10-22 16:19 ` [U-Boot] [PATCH V3 2/5] ARM: enhance u-boot.lds to detect over-sized SPL Stephen Warren
2012-10-22 17:52   ` Tom Rini [this message]
2012-10-25 18:11     ` Simon Glass
2012-10-22 16:19 ` [U-Boot] [PATCH V3 3/5] ARM: tegra: derive CONFIG_SPL_MAX_SIZE instead of hard-coding it Stephen Warren
2012-10-25 18:12   ` Simon Glass
2012-10-22 16:19 ` [U-Boot] [PATCH V3 4/5] ARM: tegra: select between Seaboard/Ventana at compile time Stephen Warren
2012-10-25 18:13   ` Simon Glass
2012-10-22 16:19 ` [U-Boot] [PATCH V3 5/5] ARM: tegra: don't request GPIO from Seaboard's SPL Stephen Warren
2012-10-25 18:15   ` Simon Glass
2012-10-27  9:15   ` Albert ARIBAUD
2012-10-28  2:09     ` Stephen Warren
2012-10-28 14:07       ` Albert ARIBAUD
2012-10-25 18:11 ` [U-Boot] [PATCH V3 1/5] ARM: fix u-boot.lds for -ffunction-sections/-fdata-sections Simon Glass
2012-10-26 21:45   ` Albert ARIBAUD

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121022175212.GB11518@bill-the-cat \
    --to=trini@ti.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.