From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Subject: Re: [PATCH 3/5] arm: mvebu: Added IPI support via doorbells Date: Mon, 22 Oct 2012 22:07:08 +0200 Message-ID: <20121022200708.GO21046@lunn.ch> References: <1350925368-24243-1-git-send-email-gregory.clement@free-electrons.com> <1350925368-24243-4-git-send-email-gregory.clement@free-electrons.com> <20121022173028.GM21046@lunn.ch> <50859976.6080601@free-electrons.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <50859976.6080601@free-electrons.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Gregory CLEMENT Cc: Lior Amsalem , Andrew Lunn , Ike Pan , Will Deacon , Nadav Haklai , Ian Molton , David Marlin , Yehuda Yitschak , Jani Monoses , Russell King , Tawfik Bayouk , Dan Frazier , Eran Ben-Avi , Li Li , Leif Lindholm , Sebastian Hesselbarth , Jason Cooper , Arnd Bergmann , Jon Masters , devicetree-discuss@lists.ozlabs.org, Rob Herring , Ben Dooks , Mike Turquette , linux-arm-kernel@lists.infradead.or List-Id: devicetree@vger.kernel.org On Mon, Oct 22, 2012 at 09:07:34PM +0200, Gregory CLEMENT wrote: > On 10/22/2012 07:30 PM, Andrew Lunn wrote: > > On Mon, Oct 22, 2012 at 07:02:45PM +0200, Gregory CLEMENT wrote: > >> From: Yehuda Yitschak > >> > >> Signed-off-by: Yehuda Yitschak > >> Signed-off-by: Gregory CLEMENT > >> --- > >> arch/arm/boot/dts/armada-xp.dtsi | 2 +- > >> arch/arm/mach-mvebu/armada-370-xp.h | 10 ++++ > >> arch/arm/mach-mvebu/irq-armada-370-xp.c | 92 +++++++++++++++++++++++++++++-- > >> 3 files changed, 97 insertions(+), 7 deletions(-) > >> > >> diff --git a/arch/arm/boot/dts/armada-xp.dtsi b/arch/arm/boot/dts/armada-xp.dtsi > >> index f521ed8..531619f 100644 > >> --- a/arch/arm/boot/dts/armada-xp.dtsi > >> +++ b/arch/arm/boot/dts/armada-xp.dtsi > >> @@ -24,7 +24,7 @@ > >> > >> mpic: interrupt-controller@d0020000 { > >> reg = <0xd0020a00 0x1d0>, > >> - <0xd0021870 0x58>; > >> + <0xd0021070 0x58>; > >> }; > > > > Hi Gregory > > > > Is this a bug fix needed for 3.7? > > > > Andrew > > > I don't think so. > We extended the reg map to be able to use registers only used for SMP. > When we didn't have SMP support the mapping was correct, and now by > introducing SMP we extend it. The length has stayed the same, so its not extended. Its now 0x800 bytes earlier in the address space. Andrew From mboxrd@z Thu Jan 1 00:00:00 1970 From: andrew@lunn.ch (Andrew Lunn) Date: Mon, 22 Oct 2012 22:07:08 +0200 Subject: [PATCH 3/5] arm: mvebu: Added IPI support via doorbells In-Reply-To: <50859976.6080601@free-electrons.com> References: <1350925368-24243-1-git-send-email-gregory.clement@free-electrons.com> <1350925368-24243-4-git-send-email-gregory.clement@free-electrons.com> <20121022173028.GM21046@lunn.ch> <50859976.6080601@free-electrons.com> Message-ID: <20121022200708.GO21046@lunn.ch> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, Oct 22, 2012 at 09:07:34PM +0200, Gregory CLEMENT wrote: > On 10/22/2012 07:30 PM, Andrew Lunn wrote: > > On Mon, Oct 22, 2012 at 07:02:45PM +0200, Gregory CLEMENT wrote: > >> From: Yehuda Yitschak > >> > >> Signed-off-by: Yehuda Yitschak > >> Signed-off-by: Gregory CLEMENT > >> --- > >> arch/arm/boot/dts/armada-xp.dtsi | 2 +- > >> arch/arm/mach-mvebu/armada-370-xp.h | 10 ++++ > >> arch/arm/mach-mvebu/irq-armada-370-xp.c | 92 +++++++++++++++++++++++++++++-- > >> 3 files changed, 97 insertions(+), 7 deletions(-) > >> > >> diff --git a/arch/arm/boot/dts/armada-xp.dtsi b/arch/arm/boot/dts/armada-xp.dtsi > >> index f521ed8..531619f 100644 > >> --- a/arch/arm/boot/dts/armada-xp.dtsi > >> +++ b/arch/arm/boot/dts/armada-xp.dtsi > >> @@ -24,7 +24,7 @@ > >> > >> mpic: interrupt-controller at d0020000 { > >> reg = <0xd0020a00 0x1d0>, > >> - <0xd0021870 0x58>; > >> + <0xd0021070 0x58>; > >> }; > > > > Hi Gregory > > > > Is this a bug fix needed for 3.7? > > > > Andrew > > > I don't think so. > We extended the reg map to be able to use registers only used for SMP. > When we didn't have SMP support the mapping was correct, and now by > introducing SMP we extend it. The length has stayed the same, so its not extended. Its now 0x800 bytes earlier in the address space. Andrew