All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: SeongJae Park <sj38.park@gmail.com>
Cc: Lauri Hintsala <lauri.hintsala@bluegiga.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: csr: fix coding style
Date: Mon, 22 Oct 2012 19:53:04 -0700	[thread overview]
Message-ID: <20121023025304.GA21810@kroah.com> (raw)
In-Reply-To: <CAEjAshqiVPA86fYNehmAEqiiZt0tGBvhu3ntFy+7XA4oLZKtRg@mail.gmail.com>

On Tue, Oct 23, 2012 at 11:41:06AM +0900, SeongJae Park wrote:
> Hello,
> 
> 
> I think it was my mistake.
> 
> CsrThread is enclosed by macro #ifdef __KERNEL__
> and it used by csr_framework_ext.h as CsrThreadHandle type(typedef
> used at csr_framework_ext_types.h).
> 
> I think that's why I didn't see build failure.

When building the driver __KERNEL__ is defined :)

> So, I think I should not remove CsrThread.
> If there is anything I missed or wrong, Please let me know.

No, you are right, this can't be removed just yet, so all is good.

If you want to send more patches cleaning stuff up like this one, that
would be great.

thanks,

greg k-h

  reply	other threads:[~2012-10-23  2:52 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-15  7:55 [PATCH] staging: csr: fix coding style SeongJae Park
2012-10-16  7:13 ` Lauri Hintsala
2012-10-22 20:56   ` Greg KH
2012-10-23  2:13     ` SeongJae Park
2012-10-23  2:41       ` SeongJae Park
2012-10-23  2:53         ` Greg KH [this message]
2012-10-23  3:07           ` SeongJae Park
2012-10-25  6:54 [PATCH] staging: csr: Fix " SeongJae Park

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121023025304.GA21810@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=lauri.hintsala@bluegiga.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sj38.park@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.