From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:35299) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TQW0r-00020Z-NP for qemu-devel@nongnu.org; Tue, 23 Oct 2012 00:22:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TQW0q-0005m1-OR for qemu-devel@nongnu.org; Tue, 23 Oct 2012 00:22:45 -0400 Received: from mail.valinux.co.jp ([210.128.90.3]:33228) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TQW0q-0005kX-9F for qemu-devel@nongnu.org; Tue, 23 Oct 2012 00:22:44 -0400 Date: Tue, 23 Oct 2012 13:22:39 +0900 From: Isaku Yamahata Message-ID: <20121023042239.GG6574@valinux.co.jp> References: <09d1ef33fe429510a94ec4c8a5c40de83764eea7.1350677361.git.jbaron@redhat.com> <20121022112743.GF30844@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20121022112743.GF30844@redhat.com> Subject: Re: [Qemu-devel] [PATCH v3 13/26] ich9: Add the lpc chip List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: aliguori@us.ibm.com, juzhang@redhat.com, jan.kiszka@siemens.com, Jason Baron , qemu-devel@nongnu.org, agraf@suse.de, blauwirbel@gmail.com, alex.williamson@redhat.com, kevin@koconnor.net, avi@redhat.com, mkletzan@redhat.com, pbonzini@redhat.com, lcapitulino@redhat.com, afaerber@suse.de, armbru@redhat.com, kraxel@redhat.com On Mon, Oct 22, 2012 at 01:27:43PM +0200, Michael S. Tsirkin wrote: > > diff --git a/hw/lpc_ich9.c b/hw/lpc_ich9.c > > new file mode 100644 > > index 0000000..d9fd9de > > --- /dev/null > > +++ b/hw/lpc_ich9.c > > @@ -0,0 +1,523 @@ > > +/* > > + * Copyright (c) 2006 Fabrice Bellard > > + * > > + * Permission is hereby granted, free of charge, to any person obtaining a copy > > + * of this software and associated documentation files (the "Software"), to deal > > + * in the Software without restriction, including without limitation the rights > > + * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell > > + * copies of the Software, and to permit persons to whom the Software is > > + * furnished to do so, subject to the following conditions: > > + * > > + * The above copyright notice and this permission notice shall be included in > > + * all copies or substantial portions of the Software. > > + * > > + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR > > + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, > > + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL > > + * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER > > + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, > > + * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN > > + * THE SOFTWARE. > > + */ > > Above is confusing until one notices the below "this is based on piix_pci.c" > and looks at that file. > > I think it's best to just use copyright Fabrice selected for all of this file. > Jason, Isaku, could you please both respond whether it's OK with > you both? I'm fine with it. This applies to other files. -- yamahata