From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: linux-kernel@vger.kernel.org, xen-devel@lists.xensource.com,
mukesh.rathor@oracle.com, Ian.Campbell@citrix.com,
stefano.stabellini@eu.citrix.com
Subject: Re: [PATCH 1/6] xen/pvh: Support ParaVirtualized Hardware extensions.
Date: Tue, 23 Oct 2012 10:07:53 -0400 [thread overview]
Message-ID: <20121023140753.GB14100@phenom.dumpdata.com> (raw)
In-Reply-To: <1350695882-12820-2-git-send-email-konrad.wilk@oracle.com>
> +/*
> + * Unmaps the page appearing at a particular GPFN from the specified guest's
> + * pseudophysical address space.
> + * arg == addr of xen_remove_from_physmap_t.
> + */
> +#define XENMEM_remove_from_physmap 15
> +struct xen_remove_from_physmap {
> + /* Which domain to change the mapping for. */
> + domid_t domid;
> +
> + /* GPFN of the current mapping of the page. */
> + xen_pfn_t gpfn;
> +};
I just realized that this a bit of unfortunate. We end up
with on 64-bit with this layout:
{
0->1 [domid]
2->7 [nothing]
8->16 [gpfn]
}
which if one were to do a 32-bit build you would get:
{
0->1 [domid]
2->3 [nothing]
4->7 [gpfn]
}
which means another compat layer in Xen.
So I think it makes sense to modify this to be 32 and 64-bit
clean, something like this:
{
domid_t domid;
u8 pad[6];
xen_pfn_t gpfn;
/* xen_pfn_t under 32-bit x86 is 4 bytes, so extend it */
#ifdef CONFIG_X86_32
__u8 pad1[4];
#endif
}
that way the structure is exactly the same size and the offsets
align.
Mukesh, you OK with that?
next prev parent reply other threads:[~2012-10-23 14:20 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-20 1:17 Konrad Rzeszutek Wilk
2012-10-20 1:17 ` (unknown), Konrad Rzeszutek Wilk
2012-10-20 1:17 ` [PATCH 1/6] xen/pvh: Support ParaVirtualized Hardware extensions Konrad Rzeszutek Wilk
2012-10-22 13:38 ` Stefano Stabellini
2012-10-23 14:07 ` Konrad Rzeszutek Wilk [this message]
2012-10-24 9:29 ` Ian Campbell
2012-10-23 14:46 ` Konrad Rzeszutek Wilk
2012-10-24 9:27 ` Ian Campbell
2012-10-20 1:17 ` [PATCH 2/6] xen/pvh: Extend vcpu_guest_context, p2m, event, and xenbus to support PVH Konrad Rzeszutek Wilk
2012-10-22 13:44 ` Stefano Stabellini
2012-10-22 15:40 ` Konrad Rzeszutek Wilk
2012-10-22 15:40 ` Konrad Rzeszutek Wilk
2012-10-22 18:31 ` Mukesh Rathor
2012-10-22 20:14 ` Konrad Rzeszutek Wilk
2012-10-22 20:39 ` Mukesh Rathor
2012-10-23 12:25 ` Stefano Stabellini
2012-10-20 1:17 ` [PATCH 3/6] xen/pvh: Implements mmu changes for PVH Konrad Rzeszutek Wilk
2012-10-22 13:46 ` Stefano Stabellini
2012-10-20 1:18 ` [PATCH 4/6] xen/pvh: bootup and setup related changes Konrad Rzeszutek Wilk
2012-10-22 13:34 ` Stefano Stabellini
2012-10-22 15:57 ` Konrad Rzeszutek Wilk
2012-10-23 13:07 ` Stefano Stabellini
2012-10-23 23:47 ` Mukesh Rathor
2012-10-23 23:47 ` Mukesh Rathor
2012-10-24 0:03 ` [Xen-devel] " Mukesh Rathor
2012-10-24 0:10 ` Mukesh Rathor
2012-10-25 12:38 ` Konrad Rzeszutek Wilk
2012-10-20 1:18 ` [PATCH 5/6] xen/pvh: balloon and grant changes Konrad Rzeszutek Wilk
2012-10-22 13:25 ` Stefano Stabellini
2012-10-22 16:04 ` Konrad Rzeszutek Wilk
2012-10-22 16:40 ` Stefano Stabellini
2012-10-20 1:18 ` [PATCH 6/6] xen/pvh: /dev/xen/privcmd changes Konrad Rzeszutek Wilk
2012-10-22 13:22 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121023140753.GB14100@phenom.dumpdata.com \
--to=konrad.wilk@oracle.com \
--cc=Ian.Campbell@citrix.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mukesh.rathor@oracle.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.