From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760076Ab2JYSIV (ORCPT ); Thu, 25 Oct 2012 14:08:21 -0400 Received: from mail-pb0-f46.google.com ([209.85.160.46]:33608 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760064Ab2JYSIR (ORCPT ); Thu, 25 Oct 2012 14:08:17 -0400 Date: Thu, 25 Oct 2012 11:08:12 -0700 From: Tejun Heo To: Glauber Costa Cc: JoonSoo Kim , linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, Mel Gorman , Andrew Morton , Michal Hocko , Johannes Weiner , kamezawa.hiroyu@jp.fujitsu.com, Christoph Lameter , David Rientjes , Pekka Enberg , devel@openvz.org, Pekka Enberg , Suleiman Souhlal Subject: Re: [PATCH v5 08/18] memcg: infrastructure to match an allocation to the right cache Message-ID: <20121025180812.GN11442@htj.dyndns.org> References: <1350656442-1523-1-git-send-email-glommer@parallels.com> <1350656442-1523-9-git-send-email-glommer@parallels.com> <50891CF2.3030400@parallels.com> <20121025180652.GM11442@htj.dyndns.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20121025180652.GM11442@htj.dyndns.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 25, 2012 at 11:06:52AM -0700, Tejun Heo wrote: > Hello, Glauber. > > On Thu, Oct 25, 2012 at 03:05:22PM +0400, Glauber Costa wrote: > > > Is there any rmb() pair? > > > As far as I know, without rmb(), wmb() doesn't guarantee anything. > > > > > > > There should be. But it seems I missed it. Speaking of which, I should > > You probably can use read_barrier_depends(). Ooh, and when you use memory barrier pairs, please make sure to comment on both sides explaining how they're paired and why. There's nothing more frustrating than barriers without clear annotation. Thanks. -- tejun From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: [PATCH v5 08/18] memcg: infrastructure to match an allocation to the right cache Date: Thu, 25 Oct 2012 11:08:12 -0700 Message-ID: <20121025180812.GN11442@htj.dyndns.org> References: <1350656442-1523-1-git-send-email-glommer@parallels.com> <1350656442-1523-9-git-send-email-glommer@parallels.com> <50891CF2.3030400@parallels.com> <20121025180652.GM11442@htj.dyndns.org> Mime-Version: 1.0 Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=4Vyg53IcPz0XksIephJsV4D5dNyMesfV2/NdaVr1Ybk=; b=s6VoXvtugz6Zp0f3JVAUS5/k9rldgu7F9LfbMwcWhSRxuUkDGlZs7VhdPZbyfn7qgQ JzYh8Q7KVi+ZwBRFan7V3e21SBNb2wdb6RC8w8wf+lykn8P350LvD15CkzNyq0l4aCJm 8DwNlLBOTgocQ6fsL7UOy+X78XgQKCaOrGzOrqiAoGR+6v+P/8L75tUgRJDkUcgBUe8g nbeM80BZsE+PYwMXU8IMHy4ReN/VosrLOjwuNvg16iI8T33Jf8xJ0u10RPLJRIra+D6S vXzuVC0JOYviGi0DmrutgFK8tEKGLKwzXfi3P/cn+A5Uo29WPuianl47BLQbXKe0qiq4 5XTQ== Content-Disposition: inline In-Reply-To: <20121025180652.GM11442@htj.dyndns.org> Sender: owner-linux-mm@kvack.org List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Glauber Costa Cc: JoonSoo Kim , linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, Mel Gorman , Andrew Morton , Michal Hocko , Johannes Weiner , kamezawa.hiroyu@jp.fujitsu.com, Christoph Lameter , David Rientjes , Pekka Enberg , devel@openvz.org, Pekka Enberg , Suleiman Souhlal On Thu, Oct 25, 2012 at 11:06:52AM -0700, Tejun Heo wrote: > Hello, Glauber. > > On Thu, Oct 25, 2012 at 03:05:22PM +0400, Glauber Costa wrote: > > > Is there any rmb() pair? > > > As far as I know, without rmb(), wmb() doesn't guarantee anything. > > > > > > > There should be. But it seems I missed it. Speaking of which, I should > > You probably can use read_barrier_depends(). Ooh, and when you use memory barrier pairs, please make sure to comment on both sides explaining how they're paired and why. There's nothing more frustrating than barriers without clear annotation. Thanks. -- tejun -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org