From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757183Ab2JZH70 (ORCPT ); Fri, 26 Oct 2012 03:59:26 -0400 Received: from mail-wg0-f44.google.com ([74.125.82.44]:39069 "EHLO mail-wg0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757073Ab2JZH7Z (ORCPT ); Fri, 26 Oct 2012 03:59:25 -0400 Date: Fri, 26 Oct 2012 09:59:19 +0200 From: Ingo Molnar To: Andi Kleen Cc: Peter Zijlstra , Rik van Riel , Andrea Arcangeli , Mel Gorman , Johannes Weiner , Thomas Gleixner , Linus Torvalds , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Lee Schermerhorn Subject: Re: [PATCH 10/31] mm/mpol: Remove NUMA_INTERLEAVE_HIT Message-ID: <20121026075919.GA18211@gmail.com> References: <20121025121617.617683848@chello.nl> <20121025124833.247790041@chello.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Andi Kleen wrote: > Peter Zijlstra writes: > > > Since the NUMA_INTERLEAVE_HIT statistic is useless on its > > own; it wants to be compared to either a total of interleave > > allocations or to a miss count, remove it. > > > > Fixing it would be possible, but since we've gone years > > without these statistics I figure we can continue that way. > > > > Also NUMA_HIT fully includes NUMA_INTERLEAVE_HIT so users > > might switch to using that. > > > > This cleans up some of the weird MPOL_INTERLEAVE allocation > > exceptions. > > NACK, as already posted several times. > > This breaks the numactl test suite, which is the only way > currently to test interleaving. This patch is not essential to the NUMA series so I've zapped it from the patch queue and fixed up the roll-on effects. Thanks, Ingo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx198.postini.com [74.125.245.198]) by kanga.kvack.org (Postfix) with SMTP id 8425E6B0071 for ; Fri, 26 Oct 2012 03:59:25 -0400 (EDT) Received: by mail-wi0-f169.google.com with SMTP id hq4so191098wib.2 for ; Fri, 26 Oct 2012 00:59:23 -0700 (PDT) Date: Fri, 26 Oct 2012 09:59:19 +0200 From: Ingo Molnar Subject: Re: [PATCH 10/31] mm/mpol: Remove NUMA_INTERLEAVE_HIT Message-ID: <20121026075919.GA18211@gmail.com> References: <20121025121617.617683848@chello.nl> <20121025124833.247790041@chello.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: owner-linux-mm@kvack.org List-ID: To: Andi Kleen Cc: Peter Zijlstra , Rik van Riel , Andrea Arcangeli , Mel Gorman , Johannes Weiner , Thomas Gleixner , Linus Torvalds , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Lee Schermerhorn * Andi Kleen wrote: > Peter Zijlstra writes: > > > Since the NUMA_INTERLEAVE_HIT statistic is useless on its > > own; it wants to be compared to either a total of interleave > > allocations or to a miss count, remove it. > > > > Fixing it would be possible, but since we've gone years > > without these statistics I figure we can continue that way. > > > > Also NUMA_HIT fully includes NUMA_INTERLEAVE_HIT so users > > might switch to using that. > > > > This cleans up some of the weird MPOL_INTERLEAVE allocation > > exceptions. > > NACK, as already posted several times. > > This breaks the numactl test suite, which is the only way > currently to test interleaving. This patch is not essential to the NUMA series so I've zapped it from the patch queue and fixed up the roll-on effects. Thanks, Ingo -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org