From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752400Ab2J1NKW (ORCPT ); Sun, 28 Oct 2012 09:10:22 -0400 Received: from mail-ea0-f174.google.com ([209.85.215.174]:51994 "EHLO mail-ea0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752094Ab2J1NKU (ORCPT ); Sun, 28 Oct 2012 09:10:20 -0400 Date: Sun, 28 Oct 2012 14:10:14 +0100 From: Ingo Molnar To: Gerald Schaefer Cc: Stephen Rothwell , Martin Schwidefsky , Heiko Carstens , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Peter Zijlstra , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, Ralf Baechle , Peter Zijlstra Subject: [PATCH] s390: Add pmd_mknotpresent() Message-ID: <20121028131014.GA10754@gmail.com> References: <20121018172201.b81dcc8fe40868256f532364@canb.auug.org.au> <20121018182642.2a541275@thinkpad> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20121018182642.2a541275@thinkpad> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org There's a related problem on s390: other THP implementations have pmd_mknotpresent() while s390 not, resulting in: mm/huge_memory.c:1543:2: error: implicit declaration of function 'pmd_mknotpresent' The (untested!) patch below adds the s390 version of this method. Gerald, Martin, did I get the S390 details right? Thanks, Ingo Signed-off-by: Ingo Molnar --- diff --git a/arch/s390/include/asm/pgtable.h b/arch/s390/include/asm/pgtable.h index 098fc5a..b820ff1 100644 --- a/arch/s390/include/asm/pgtable.h +++ b/arch/s390/include/asm/pgtable.h @@ -1310,6 +1310,12 @@ static inline pmd_t pmd_mkyoung(pmd_t pmd) return pmd; } +static inline pmd_t pmd_mknotpresent(pmd_t pmd) +{ + pmd_val(pmd) &= ~_SEGMENT_ENTRY_ORIGIN; + return pmd; +} + #define __HAVE_ARCH_PMDP_TEST_AND_CLEAR_YOUNG static inline int pmdp_test_and_clear_young(struct vm_area_struct *vma, unsigned long address, pmd_t *pmdp)