All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@redhat.com>
To: Jiri Olsa <jolsa@redhat.com>
Cc: linux-kernel@vger.kernel.org,
	Corey Ashford <cjashfor@linux.vnet.ibm.com>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Ingo Molnar <mingo@elte.hu>, Namhyung Kim <namhyung@kernel.org>,
	Paul Mackerras <paulus@samba.org>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [PATCH 5/5] perf tool: Move dso_* related functions into dso object
Date: Sun, 28 Oct 2012 11:37:02 -0200	[thread overview]
Message-ID: <20121028133702.GA6754@infradead.org> (raw)
In-Reply-To: <1351372712-21104-6-git-send-email-jolsa@redhat.com>

Em Sat, Oct 27, 2012 at 11:18:32PM +0200, Jiri Olsa escreveu:
> Moving dso_* related functions into dso object.
> 
> Keeping symbol loading related functions still in the symbol
> object as it seems more convenient.

Please resubmit after you fix this: The other 4 patches I already applied to my local tree.

- Arnaldo

    CC /home/acme/git/build/perf/util/dso-test-data.o
In file included from util/dso.c:2:
util/dso.h:87: error: ‘BUILD_ID_SIZE’ undeclared here (not in a function)
    CC /home/acme/git/build/perf/util/color.o
cc1: warnings being treated as errors
util/dso.c: In function ‘dso__binary_type_file’:
util/dso.c:45: error: implicit declaration of function ‘filename__read_debuglink’
util/dso.c:45: error: nested extern declaration of ‘filename__read_debuglink’
util/dso.c:51: error: ‘symbol_conf’ undeclared (first use in this function)
util/dso.c:51: error: (Each undeclared identifier is reported only once
util/dso.c:51: error: for each function it appears in.)
util/dso.c: In function ‘dso__delete’:
util/dso.c:435: error: implicit declaration of function ‘symbols__delete’
util/dso.c:435: error: nested extern declaration of ‘symbols__delete’
util/dso.c: In function ‘dso__read_running_kernel_build_id’:
util/dso.c:462: error: implicit declaration of function ‘sysfs__read_build_id’
util/dso.c:462: error: nested extern declaration of ‘sysfs__read_build_id’
util/dso.c: In function ‘__dsos__read_build_ids’:
util/dso.c:500: error: implicit declaration of function ‘filename__read_build_id’
util/dso.c:500: error: nested extern declaration of ‘filename__read_build_id’
util/dso.c: In function ‘dso__fprintf’:
util/dso.c:589: error: dereferencing pointer to incomplete type
util/dso.c:589: error: type defaults to ‘int’ in declaration of ‘__mptr’
util/dso.c:589: error: initialization from incompatible pointer type
util/dso.c:589: error: invalid use of undefined type ‘struct symbol’
util/dso.c:590: error: implicit declaration of function ‘symbol__fprintf’
util/dso.c:590: error: nested extern declaration of ‘symbol__fprintf’
make: *** [/home/acme/git/build/perf/util/dso.o] Error 1
make: *** Waiting for unfinished jobs....
make: Leaving directory `/home/git/linux/tools/perf'
[acme@sandy linux]$ 

  reply	other threads:[~2012-10-28 13:37 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-27 21:18 [PATCH 0/5] perf dso: Separate dso symbols to separate object Jiri Olsa
2012-10-27 21:18 ` [PATCH 1/5] perf tool: Move build_id__sprintf into build-id object Jiri Olsa
2012-10-30 11:59   ` [tip:perf/core] perf tools: " tip-bot for Jiri Olsa
2012-10-27 21:18 ` [PATCH 2/5] perf tool: Move BUILD_ID_SIZE " Jiri Olsa
2012-10-30 12:00   ` [tip:perf/core] perf tools: " tip-bot for Jiri Olsa
2012-10-27 21:18 ` [PATCH 3/5] perf tool: Move hex2u64 into util object Jiri Olsa
2012-10-30 12:01   ` [tip:perf/core] perf tools: " tip-bot for Jiri Olsa
2012-10-27 21:18 ` [PATCH 4/5] perf tool: Move strxfrchar into string object Jiri Olsa
2012-10-30 12:02   ` [tip:perf/core] perf tools: " tip-bot for Jiri Olsa
2012-10-27 21:18 ` [PATCH 5/5] perf tool: Move dso_* related functions into dso object Jiri Olsa
2012-10-28 13:37   ` Arnaldo Carvalho de Melo [this message]
2012-10-28 18:42     ` Jiri Olsa
2012-10-28 21:16       ` Arnaldo Carvalho de Melo
2012-10-30 12:04   ` [tip:perf/core] perf tools: " tip-bot for Jiri Olsa
2012-10-29 11:07 ` [PATCH 0/5] perf dso: Separate dso symbols to separate object Namhyung Kim
2012-10-29 11:13   ` Jiri Olsa
2012-10-29 11:20     ` Namhyung Kim
2012-10-29 13:33     ` Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121028133702.GA6754@infradead.org \
    --to=acme@redhat.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=cjashfor@linux.vnet.ibm.com \
    --cc=fweisbec@gmail.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=namhyung@kernel.org \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.