From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: [PATCH 7/7] Remove get_device() / put_device() pair from scsi_request_fn() Date: Sun, 28 Oct 2012 19:08:22 -0700 Message-ID: <20121029020822.GI5171@htj.dyndns.org> References: <508A7B63.60608@acm.org> <508A7C9B.5020800@acm.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-pa0-f46.google.com ([209.85.220.46]:37447 "EHLO mail-pa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757384Ab2J2CI1 (ORCPT ); Sun, 28 Oct 2012 22:08:27 -0400 Received: by mail-pa0-f46.google.com with SMTP id hz1so3068235pad.19 for ; Sun, 28 Oct 2012 19:08:27 -0700 (PDT) Content-Disposition: inline In-Reply-To: <508A7C9B.5020800@acm.org> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Bart Van Assche Cc: linux-scsi , James Bottomley , Mike Christie , Jens Axboe , Chanho Min On Fri, Oct 26, 2012 at 02:05:47PM +0200, Bart Van Assche wrote: > Since all scsi_request_fn() callers hold a reference on the Maybe s/Since/Now that/ > SCSI device that function is invoked for and since > blk_cleanup_queue() waits until scsi_request_fn() has finished > it is safe to remove the get_device() / put_device() pair from > scsi_request_fn(). > > Cc: James Bottomley > Cc: Mike Christie > Cc: Jens Axboe > Cc: Tejun Heo > Signed-off-by: Bart Van Assche Acked-by: Tejun Heo Thanks. -- tejun