From mboxrd@z Thu Jan 1 00:00:00 1970 From: Antonio Quartulli Subject: Re: [PATCH 03/16] batman-adv: separate BATADV_ATTR_HIF_UINT sysfs name from hard-iface variable Date: Mon, 29 Oct 2012 09:13:40 +0100 Message-ID: <20121029081340.GA5944@ritirata.org> References: <1351423037-5292-1-git-send-email-ordex@autistici.org> <1351423037-5292-4-git-send-email-ordex@autistici.org> <20121028.185927.374901219739099234.davem@davemloft.net> Reply-To: The list for a Better Approach To Mobile Ad-hoc Networking Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="1yeeQ81UyVL57Vl7" Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, b.a.t.m.a.n-ZwoEplunGu2X36UT3dwllkB+6BGkLq7r@public.gmane.org, lindner_marek-LWAfsSFWpa4@public.gmane.org To: David Miller Return-path: Content-Disposition: inline In-Reply-To: <20121028.185927.374901219739099234.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: b.a.t.m.a.n-bounces-ZwoEplunGu2X36UT3dwllkB+6BGkLq7r@public.gmane.org Sender: "B.A.T.M.A.N" List-Id: netdev.vger.kernel.org --1yeeQ81UyVL57Vl7 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hello David, On Sun, Oct 28, 2012 at 06:59:27PM -0400, David Miller wrote: > From: Antonio Quartulli > Date: Sun, 28 Oct 2012 12:17:04 +0100 >=20 > > From: Marek Lindner > >=20 > > Signed-off-by: Marek Lindner > > Signed-off-by: Antonio Quartulli > > --- > > net/batman-adv/sysfs.c | 15 ++++++++------- > > 1 file changed, 8 insertions(+), 7 deletions(-) >=20 > I was wondering how you could possibly change the list of arguments to > these macros, yet avoid changing any of the users. >=20 > And sure enough it's because these macros are completely unused. when this macro was introduced a user was going to be added as well, but th= en we delayed some work and the user was not introduced anymore.. >=20 > Please just remove them instead of changing their interfaces when no > users exist. Yes, I will resend the pull request with a patch that removes this macro at= all. We will re-introduce it as soon as the user is ready too. Cheers, --=20 Antonio Quartulli =2E.each of us alone is worth nothing.. Ernesto "Che" Guevara --1yeeQ81UyVL57Vl7 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) iEYEARECAAYFAlCOOrQACgkQpGgxIkP9cwfnUwCeJox1sRMZlt9FwShaPHzfFxgB uoMAmwcaNEQCA3PafurKoMBY/JtpbPdl =J6D5 -----END PGP SIGNATURE----- --1yeeQ81UyVL57Vl7-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Mon, 29 Oct 2012 09:13:40 +0100 From: Antonio Quartulli Message-ID: <20121029081340.GA5944@ritirata.org> References: <1351423037-5292-1-git-send-email-ordex@autistici.org> <1351423037-5292-4-git-send-email-ordex@autistici.org> <20121028.185927.374901219739099234.davem@davemloft.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="1yeeQ81UyVL57Vl7" Content-Disposition: inline In-Reply-To: <20121028.185927.374901219739099234.davem@davemloft.net> Subject: Re: [B.A.T.M.A.N.] [PATCH 03/16] batman-adv: separate BATADV_ATTR_HIF_UINT sysfs name from hard-iface variable Reply-To: The list for a Better Approach To Mobile Ad-hoc Networking List-Id: The list for a Better Approach To Mobile Ad-hoc Networking List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Miller Cc: netdev@vger.kernel.org, b.a.t.m.a.n@lists.open-mesh.org, lindner_marek@yahoo.de --1yeeQ81UyVL57Vl7 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hello David, On Sun, Oct 28, 2012 at 06:59:27PM -0400, David Miller wrote: > From: Antonio Quartulli > Date: Sun, 28 Oct 2012 12:17:04 +0100 >=20 > > From: Marek Lindner > >=20 > > Signed-off-by: Marek Lindner > > Signed-off-by: Antonio Quartulli > > --- > > net/batman-adv/sysfs.c | 15 ++++++++------- > > 1 file changed, 8 insertions(+), 7 deletions(-) >=20 > I was wondering how you could possibly change the list of arguments to > these macros, yet avoid changing any of the users. >=20 > And sure enough it's because these macros are completely unused. when this macro was introduced a user was going to be added as well, but th= en we delayed some work and the user was not introduced anymore.. >=20 > Please just remove them instead of changing their interfaces when no > users exist. Yes, I will resend the pull request with a patch that removes this macro at= all. We will re-introduce it as soon as the user is ready too. Cheers, --=20 Antonio Quartulli =2E.each of us alone is worth nothing.. Ernesto "Che" Guevara --1yeeQ81UyVL57Vl7 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) iEYEARECAAYFAlCOOrQACgkQpGgxIkP9cwfnUwCeJox1sRMZlt9FwShaPHzfFxgB uoMAmwcaNEQCA3PafurKoMBY/JtpbPdl =J6D5 -----END PGP SIGNATURE----- --1yeeQ81UyVL57Vl7--