From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933823Ab2J3Pur (ORCPT ); Tue, 30 Oct 2012 11:50:47 -0400 Received: from mail-da0-f46.google.com ([209.85.210.46]:54194 "EHLO mail-da0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933789Ab2J3Pup (ORCPT ); Tue, 30 Oct 2012 11:50:45 -0400 Date: Tue, 30 Oct 2012 08:50:41 -0700 From: Greg KH To: Dmitry Torokhov Cc: George Zhang , pv-drivers@vmware.com, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org Subject: Re: [Pv-drivers] [PATCH 05/12] VMCI: event handling implementation. Message-ID: <20121030155041.GF14167@kroah.com> References: <20121030005923.17788.21797.stgit@promb-2n-dhcp175.eng.vmware.com> <20121030010420.17788.59187.stgit@promb-2n-dhcp175.eng.vmware.com> <20121030022605.GG1920@kroah.com> <20121030050152.GE32055@dtor-ws.eng.vmware.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20121030050152.GE32055@dtor-ws.eng.vmware.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 29, 2012 at 10:01:52PM -0700, Dmitry Torokhov wrote: > On Mon, Oct 29, 2012 at 07:26:05PM -0700, Greg KH wrote: > > On Mon, Oct 29, 2012 at 06:04:27PM -0700, George Zhang wrote: > > > +static void event_signal_destroy(struct kref *kref) > > > +{ > > > + struct vmci_subscription *entry = > > > + container_of(kref, struct vmci_subscription, kref); > > > + > > > + complete(&entry->done); > > > +} > > > > Didn't you just leak memory here? What frees the structure up? > > event_unregister_subscription() waits for that completion and frees the > structure. We want event_unregister_subscription() to wait until all > fired callbacks completed before unregister is complete. So all calls to this can just sit and spin waiting for others to clean up? Odd, but ok. greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [Pv-drivers] [PATCH 05/12] VMCI: event handling implementation. Date: Tue, 30 Oct 2012 08:50:41 -0700 Message-ID: <20121030155041.GF14167@kroah.com> References: <20121030005923.17788.21797.stgit@promb-2n-dhcp175.eng.vmware.com> <20121030010420.17788.59187.stgit@promb-2n-dhcp175.eng.vmware.com> <20121030022605.GG1920@kroah.com> <20121030050152.GE32055@dtor-ws.eng.vmware.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20121030050152.GE32055@dtor-ws.eng.vmware.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: Dmitry Torokhov Cc: pv-drivers@vmware.com, linux-kernel@vger.kernel.org, George Zhang , virtualization@lists.linux-foundation.org List-Id: virtualization@lists.linuxfoundation.org On Mon, Oct 29, 2012 at 10:01:52PM -0700, Dmitry Torokhov wrote: > On Mon, Oct 29, 2012 at 07:26:05PM -0700, Greg KH wrote: > > On Mon, Oct 29, 2012 at 06:04:27PM -0700, George Zhang wrote: > > > +static void event_signal_destroy(struct kref *kref) > > > +{ > > > + struct vmci_subscription *entry = > > > + container_of(kref, struct vmci_subscription, kref); > > > + > > > + complete(&entry->done); > > > +} > > > > Didn't you just leak memory here? What frees the structure up? > > event_unregister_subscription() waits for that completion and frees the > structure. We want event_unregister_subscription() to wait until all > fired callbacks completed before unregister is complete. So all calls to this can just sit and spin waiting for others to clean up? Odd, but ok. greg k-h