From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758229Ab2JaQnZ (ORCPT ); Wed, 31 Oct 2012 12:43:25 -0400 Received: from mga02.intel.com ([134.134.136.20]:39599 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757913Ab2JaQnY (ORCPT ); Wed, 31 Oct 2012 12:43:24 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.80,687,1344236400"; d="scan'208";a="213574697" Date: Wed, 31 Oct 2012 09:43:23 -0700 From: Andi Kleen To: Gleb Natapov Cc: Andi Kleen , linux-kernel@vger.kernel.org, acme@redhat.com, peterz@infradead.org, jolsa@redhat.com, eranian@google.com, mingo@kernel.org, namhyung@kernel.org, avi@redhat.com Subject: Re: [PATCH 05/32] perf, kvm: Support the intx/intx_cp modifiers in KVM arch perfmon emulation v3 Message-ID: <20121031164323.GB28297@tassilo.jf.intel.com> References: <1351643663-23828-1-git-send-email-andi@firstfloor.org> <1351643663-23828-6-git-send-email-andi@firstfloor.org> <20121031102701.GB25650@redhat.com> <20121031103248.GX16230@one.firstfloor.org> <20121031103816.GD25650@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20121031103816.GD25650@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 31, 2012 at 12:38:16PM +0200, Gleb Natapov wrote: > On Wed, Oct 31, 2012 at 11:32:48AM +0100, Andi Kleen wrote: > > On Wed, Oct 31, 2012 at 12:27:01PM +0200, Gleb Natapov wrote: > > > On Tue, Oct 30, 2012 at 05:33:56PM -0700, Andi Kleen wrote: > > > > From: Andi Kleen > > > > > > > > This is not arch perfmon, but older CPUs will just ignore it. This makes > > > > it possible to do at least some TSX measurements from a KVM guest > > > > > > > You are ignoring my reviews. > > > > Huh? I nearly rewrote the patch based on your feedback. > > It's much more complicated now just for the CPUID check you wanted. > > I hope all that code is worth it. > > > > If you want more changes please let me know. > > > I did comment on v3 yesterday. May be you missed it. https://lkml.org/lkml/2012/10/30/87 I did. Ok fixed. -Andi -- ak@linux.intel.com -- Speaking for myself only