From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759569Ab2KAUiP (ORCPT ); Thu, 1 Nov 2012 16:38:15 -0400 Received: from mail-gg0-f174.google.com ([209.85.161.174]:41336 "EHLO mail-gg0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756080Ab2KAUiJ (ORCPT ); Thu, 1 Nov 2012 16:38:09 -0400 Date: Thu, 1 Nov 2012 17:38:01 -0300 From: Arnaldo Carvalho de Melo To: Jiri Olsa Cc: linux-kernel@vger.kernel.org, Peter Zijlstra , Ingo Molnar , Paul Mackerras , Corey Ashford , Frederic Weisbecker Subject: Re: [PATCH 00/25] perf test: Add perf_event_attr tests Message-ID: <20121101203800.GA3911@ghostprotocols.net> References: <1351634526-1516-1-git-send-email-jolsa@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1351634526-1516-1-git-send-email-jolsa@redhat.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Tue, Oct 30, 2012 at 11:01:41PM +0100, Jiri Olsa escreveu: > hi, > this code tests the link between perf stat/record command line > options and final perf_event_attr struct values. Also it tests > the group fd linkage. > > Plus moving test related objects under 'test' directory. Ok, so I applied this to my local perf/core branch with a few changes, namely to move 24/25 to after 5/25 so that I could do, for each subsequent tests: $ make -j8 -C tools/perf/ O=/home/acme/git/build/perf install $ perf test -v perf_event_attr And see if each one passed. So at the end I changed /home/acme/libexec/perf-core/tests/attr/base-record flipping "watermark=0" to "watermark=1" and got: [root@sandy ~]# perf test perf_event_attr 13: struct perf_event_attr setup :FAILED '/home/acme/libexec/perf-core/tests/attr/test-record-count' - match failure FAILED! [root@sandy ~]# But I wanted it to show _what_ didn't match, so I tried: [root@sandy ~]# perf test -v perf_event_attr 13: struct perf_event_attr setup : --- start --- running '/home/acme/libexec/perf-core/tests/attr/test-record-count' FAILED '/home/acme/libexec/perf-core/tests/attr/test-record-count' - match failure ---- end ---- struct perf_event_attr setup: FAILED! [root@sandy ~]# Also is there a strict need for setting PERF_TEST_ATTR? I thought that if it found the /home/acme/libexec/perf-core/tests/attr/ dirs it would test it, but haven't dug deep, care to ellaborate here? Ah, I just pushed perf/core with this patchset, thanks! - Arnaldo