From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753243Ab2KDKbU (ORCPT ); Sun, 4 Nov 2012 05:31:20 -0500 Received: from mail-ea0-f174.google.com ([209.85.215.174]:51251 "EHLO mail-ea0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751154Ab2KDKbR (ORCPT ); Sun, 4 Nov 2012 05:31:17 -0500 Date: Sun, 4 Nov 2012 11:31:13 +0100 From: Lee Jones To: Lars-Peter Clausen Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, Mark Brown Subject: Re: [alsa-devel] [PATCH 5/9] ASoC: Only compile adav80x codec when a bus is defined Message-ID: <20121104103113.GB27124@gmail.com> References: <1351980150-24145-1-git-send-email-lee.jones@linaro.org> <1351980150-24145-6-git-send-email-lee.jones@linaro.org> <509623B0.2020605@metafoo.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <509623B0.2020605@metafoo.de> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thanks for reviewing Lars. Here's the result: commit c4f60d00d04abfb730a54a97204873dafc6473ae Author: Lee Jones Date: Sat Nov 3 22:54:23 2012 +0100 ASoC: Only compile adav80x codec when a bus is defined If !CONFIG_SPI and !CONFIG_I2C* then there is no point adding support for the adav80x codec as it relies on a bus to operate. This patch fixes the build warnings below when SPI and I2C are not specified in the configuration. sound/soc/codecs/adav80x.c:842:22: warning: ‘adav80x_bus_probe’ defined but not used [-Wunused-function] sound/soc/codecs/adav80x.c:863:22: warning: ‘adav80x_bus_remove’ defined but not used [-Wunused-function] Cc: Mark Brown Cc: alsa-devel@alsa-project.org Signed-off-by: Lee Jones diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig index b92759a..3ae3a4b 100644 --- a/sound/soc/codecs/Kconfig +++ b/sound/soc/codecs/Kconfig @@ -19,7 +19,7 @@ config SND_SOC_ALL_CODECS select SND_SOC_AD1980 if SND_SOC_AC97_BUS select SND_SOC_AD73311 select SND_SOC_ADAU1373 if I2C - select SND_SOC_ADAV80X + select SND_SOC_ADAV80X if SND_SOC_I2C_AND_SPI select SND_SOC_ADS117X select SND_SOC_AK4104 if SPI_MASTER select SND_SOC_AK4535 if I2C