All of lore.kernel.org
 help / color / mirror / Atom feed
* [Bug 50021] New: ext4 discard option not working on journal dissabled filesystem
@ 2012-11-03 23:22 bugzilla-daemon
  2012-11-05 13:50 ` [Bug 50021] " bugzilla-daemon
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: bugzilla-daemon @ 2012-11-03 23:22 UTC (permalink / raw)
  To: linux-ext4

https://bugzilla.kernel.org/show_bug.cgi?id=50021

           Summary: ext4 discard option not working on journal dissabled
                    filesystem
           Product: File System
           Version: 2.5
    Kernel Version: 3.6.5
          Platform: All
        OS/Version: Linux
              Tree: Mainline
            Status: NEW
          Severity: normal
          Priority: P1
         Component: ext4
        AssignedTo: fs_ext4@kernel-bugs.osdl.org
        ReportedBy: ninex@o2.pl
        Regression: No


naranek / # cat /proc/mounts|grep root
/dev/root / ext4 rw,noatime,nodiratime,discard,errors=remount-ro 0 0

naranek / # dd if=/dev/urandom of=/testfile bs=1023k count=64
64+0 przeczytanych recordów
64+0 zapisanych recordów
skopiowane 67043328 bajtów (67 MB), 6,96422 s, 9,6 MB/s
naranek / # sync
naranek / # hdparm --fibmap /testfile

/testfile:
 filesystem blocksize 4096, begins at LBA 411648; assuming 512 byte sectors.
 byte_offset  begin_LBA    end_LBA    sectors
           0  118917120  119048063     130944
naranek / # hdparm --read-sector 118917120 /dev/sda

/dev/sda:
reading sector 118917120: succeeded
021e 5507 7684 f2b7 c425 dbb7 3703 054c
c348 a9d5 f811 0269 9ec0 b620 9d9a 39ee
00ee 00ca 9012 2e2b 922e 555b da3e 4324
c5cf 0979 dc1e 9450 ca2d a5bf ae61 9dbf
6216 bd2e 18fc 4043 7cb8 5c47 1f0b a3e7
e177 ae3e 81cb 6499 c073 5a99 1f83 cd54
c34b e7fc 54bb 2ce7 7263 632d 9410 3f09
6ff4 9c1f 9650 d83b 33ac e237 f4db 600f
5950 356b 69c6 a4ca c696 9935 3f4f 469e
282e 6c5b edc9 416c 846a de55 8f1d 7d62
3403 00a9 8d3c 53f7 1e0f 1b0a 8ca9 c242
8da8 e383 81a8 d29a 8b33 e094 5cda 34d2
b1fc 28b7 d247 41b3 4048 46c1 fd00 5674
e6b5 5a4e d5ab d742 8639 630e d7db 9a02
efa3 b448 eb12 582e a815 65b5 8568 5eb1
d304 b097 4025 837a 2e02 9deb 4a65 c623
e308 4d31 8765 7a36 7d17 942e 612b 05a0
61f8 68d3 ff63 c66f d9a9 f699 bce3 334a
eb59 f003 06b5 3e6b 877c 9758 446d bed8
b2a1 9d02 5bf8 c38f 24c5 712f 37d8 2a3c
388c 27e1 ab0a 0a4b 4fc4 9ba7 7086 1d7e
add4 af87 8d6e 2269 73b7 7647 06ff b05b
75ea d82b 9763 cee5 4cb2 1211 8be7 10d5
3c1f af52 c90d fe9b 3a51 a1f5 7bbe 4617
4dfb 6c50 03d6 b373 5c39 7e91 6202 d610
1e42 7cd9 8899 33e4 f0fa ab8f 7143 5d4f
f5ee 40cf 1366 0bfc 853c 0c6e 7c84 05f7
f436 1da1 04b6 538f cca4 cb39 ce4e f70a
2e5d 2be1 7098 8118 5985 fb79 9125 f928
9f8d a0d8 ae2d 7af6 5eb8 4e1d c24f 4701
cfc7 e80c d052 3030 973e b4a7 7fa1 f2a7
479e 48b1 4fd4 4853 ef04 4c54 790a 2165
naranek / # rm testfile 
naranek / # sync
naranek / # hdparm --read-sector 118917120 /dev/sda

/dev/sda:
reading sector 118917120: succeeded
021e 5507 7684 f2b7 c425 dbb7 3703 054c
c348 a9d5 f811 0269 9ec0 b620 9d9a 39ee
00ee 00ca 9012 2e2b 922e 555b da3e 4324
c5cf 0979 dc1e 9450 ca2d a5bf ae61 9dbf
6216 bd2e 18fc 4043 7cb8 5c47 1f0b a3e7
e177 ae3e 81cb 6499 c073 5a99 1f83 cd54
c34b e7fc 54bb 2ce7 7263 632d 9410 3f09
6ff4 9c1f 9650 d83b 33ac e237 f4db 600f
5950 356b 69c6 a4ca c696 9935 3f4f 469e
282e 6c5b edc9 416c 846a de55 8f1d 7d62
3403 00a9 8d3c 53f7 1e0f 1b0a 8ca9 c242
8da8 e383 81a8 d29a 8b33 e094 5cda 34d2
b1fc 28b7 d247 41b3 4048 46c1 fd00 5674
e6b5 5a4e d5ab d742 8639 630e d7db 9a02
efa3 b448 eb12 582e a815 65b5 8568 5eb1
d304 b097 4025 837a 2e02 9deb 4a65 c623
e308 4d31 8765 7a36 7d17 942e 612b 05a0
61f8 68d3 ff63 c66f d9a9 f699 bce3 334a
eb59 f003 06b5 3e6b 877c 9758 446d bed8
b2a1 9d02 5bf8 c38f 24c5 712f 37d8 2a3c
388c 27e1 ab0a 0a4b 4fc4 9ba7 7086 1d7e
add4 af87 8d6e 2269 73b7 7647 06ff b05b
75ea d82b 9763 cee5 4cb2 1211 8be7 10d5
3c1f af52 c90d fe9b 3a51 a1f5 7bbe 4617
4dfb 6c50 03d6 b373 5c39 7e91 6202 d610
1e42 7cd9 8899 33e4 f0fa ab8f 7143 5d4f
f5ee 40cf 1366 0bfc 853c 0c6e 7c84 05f7
f436 1da1 04b6 538f cca4 cb39 ce4e f70a
2e5d 2be1 7098 8118 5985 fb79 9125 f928
9f8d a0d8 ae2d 7af6 5eb8 4e1d c24f 4701
cfc7 e80c d052 3030 973e b4a7 7fa1 f2a7
479e 48b1 4fd4 4853 ef04 4c54 790a 2165



# now same test with journal
naranek / # tune2fs -O has_journal /dev/sda2
tune2fs 1.42.6 (21-Sep-2012)
Tworzenie i-węzła kroniki: wykonano
# reboot



naranek ~ # dd if=/dev/urandom of=/testfile bs=1023k count=64
64+0 przeczytanych recordów                                                     
64+0 zapisanych recordów                                                        
skopiowane 67043328 bajtów (67 MB), 6,94757 s, 9,6 MB/s                         
naranek ~ # sync
naranek ~ #  hdparm --fibmap /testfile 

/testfile:                                                                      
 filesystem blocksize 4096, begins at LBA 411648; assuming 512 byte sectors.    
 byte_offset  begin_LBA    end_LBA    sectors                                   
           0    4982784    4999167      16384                                   
     8388608    5064704    5130239      65536                                   
    41943040    9127936    9160703      32768                                   
    58720256    9062400    9078655      16256                                   
naranek ~ # hdparm --read-sector 4982784 /dev/sda

/dev/sda:                                                                       
reading sector 4982784: succeeded                                               
fa73 1465 e2b0 87d0 eb96 3545 303a 1c49                                         
f43c 5994 d35b 3a72 c601 94da 4190 359a                                         
f3a8 746d e7ec 1749 6801 9263 0896 6e0a                                         
172d b430 e364 689f 594a 27d3 8983 687b                                         
c99b a447 b9c0 62c2 60c3 ddf5 727b 3f9e                                         
6b7a 480f 8480 bc90 a537 379c 5cf7 6baa                                         
9e7f f670 d8da 23e0 5027 508c d24a 2299                                         
9a0a d9c1 a64a 4986 01e6 18d0 b9df 8479                                         
ea40 3b94 3fe2 f6e8 846c 78ff cbc8 1bf5                                         
cda1 1176 ff74 7e21 3e9f f4ee c072 8389                                         
80f7 1e81 f64d 0553 e30f 7a91 5e0b e961                                         
23c4 147b e23d 89e9 a504 2d0d 6f7b d86a                                         
10db fb99 c951 bfd0 e88b bd4c 6d86 ac4a                                         
c90c ba2c 73de d6e1 d826 4d08 83a8 06b7                                         
f716 c7ab 02f7 c641 07c5 ad9a b3d7 fa59                                         
a844 ac2e a42b fd45 8bb5 af69 7d0e 03ce                                         
09ad 8ba9 b824 76a7 2f07 fd60 69b5 edd7                                         
2c52 cc12 db13 63b0 d120 1155 e63d 090d                                         
45fe 43ca 80a0 9569 f759 d029 57f1 f363                                         
984b 6d00 0fda ff93 05ac 8537 e01e 3aef                                         
e1db 42fe 69a8 9c8d 2142 d687 17b1 5808
ad21 e6af 3e94 f204 e283 7528 1bec 1260
723c fee6 35c5 09c4 c79b 7d14 c571 723a
4117 3496 3c60 7624 ca53 63fd d5f6 d545
cd56 c347 4905 380d ca13 2387 0ab9 1e23
4dc5 b0ef e9c5 ab40 ad78 876c 66cd 15ae
311e 8a1e 54b9 3bb3 7b2c 10a5 545b 8932
196e a160 bce6 353a 3324 0b21 9ac2 e588
0a76 3b3c 5f53 d0b4 0699 3edb 3de7 e1b4
21a2 26b1 5d17 53a5 4155 a376 ac4f b909
0f74 8e99 0480 508d 6f6c 49e7 b5f2 063f
425b f138 95dc 5d9f 4ab5 0888 cd0f 20d4
naranek ~ # rm /testfile 
naranek ~ # sync
naranek ~ # hdparm --read-sector 4982784 /dev/sda

/dev/sda:
reading sector 4982784: succeeded
ffff ffff ffff ffff ffff ffff ffff ffff
ffff ffff ffff ffff ffff ffff ffff ffff
ffff ffff ffff ffff ffff ffff ffff ffff
ffff ffff ffff ffff ffff ffff ffff ffff
ffff ffff ffff ffff ffff ffff ffff ffff
ffff ffff ffff ffff ffff ffff ffff ffff
ffff ffff ffff ffff ffff ffff ffff ffff
ffff ffff ffff ffff ffff ffff ffff ffff
ffff ffff ffff ffff ffff ffff ffff ffff
ffff ffff ffff ffff ffff ffff ffff ffff
ffff ffff ffff ffff ffff ffff ffff ffff
ffff ffff ffff ffff ffff ffff ffff ffff
ffff ffff ffff ffff ffff ffff ffff ffff
ffff ffff ffff ffff ffff ffff ffff ffff
ffff ffff ffff ffff ffff ffff ffff ffff
ffff ffff ffff ffff ffff ffff ffff ffff
ffff ffff ffff ffff ffff ffff ffff ffff
ffff ffff ffff ffff ffff ffff ffff ffff
ffff ffff ffff ffff ffff ffff ffff ffff
ffff ffff ffff ffff ffff ffff ffff ffff
ffff ffff ffff ffff ffff ffff ffff ffff
ffff ffff ffff ffff ffff ffff ffff ffff
ffff ffff ffff ffff ffff ffff ffff ffff
ffff ffff ffff ffff ffff ffff ffff ffff
ffff ffff ffff ffff ffff ffff ffff ffff
ffff ffff ffff ffff ffff ffff ffff ffff
ffff ffff ffff ffff ffff ffff ffff ffff
ffff ffff ffff ffff ffff ffff ffff ffff
ffff ffff ffff ffff ffff ffff ffff ffff
ffff ffff ffff ffff ffff ffff ffff ffff
ffff ffff ffff ffff ffff ffff ffff ffff
ffff ffff ffff ffff ffff ffff ffff ffff
naranek ~ #

-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug 50021] ext4 discard option not working on journal dissabled filesystem
  2012-11-03 23:22 [Bug 50021] New: ext4 discard option not working on journal dissabled filesystem bugzilla-daemon
@ 2012-11-05 13:50 ` bugzilla-daemon
  2012-11-05 13:58 ` bugzilla-daemon
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: bugzilla-daemon @ 2012-11-05 13:50 UTC (permalink / raw)
  To: linux-ext4

https://bugzilla.kernel.org/show_bug.cgi?id=50021


Tao Ma <tm@tao.ma> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tm@tao.ma




--- Comment #1 from Tao Ma <tm@tao.ma>  2012-11-05 13:50:28 ---
Interesting, it works fine here with my intel ssd.
So could you please do:
1. mount -t debugfs none /sys/kernel/debug/
2. echo 1 > /sys/kernel/debug/tracing/events/ext4/ext4_discard_blocks/enable 
3. run you test
4. after 'rm', do
cat /sys/kernel/debug/tracing/trace

If your see something like 
jbd2/sdb2-8-23853 [000] .... 30125.695303: ext4_discard_blocks: dev 8,18 blk
34816 count 3072
              rm-23870 [000] .... 30130.908415: ext4_discard_blocks: dev 8,17
blk 34816 count 3072

(The first one is captured by the device with journal and the second one is
captured by the device without journal).
Then that does mean ext4 has sent out the discard command to the underlying
device.

btw, my kernel version is 3.6.

-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug 50021] ext4 discard option not working on journal dissabled filesystem
  2012-11-03 23:22 [Bug 50021] New: ext4 discard option not working on journal dissabled filesystem bugzilla-daemon
  2012-11-05 13:50 ` [Bug 50021] " bugzilla-daemon
@ 2012-11-05 13:58 ` bugzilla-daemon
  2012-11-05 14:13 ` bugzilla-daemon
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: bugzilla-daemon @ 2012-11-05 13:58 UTC (permalink / raw)
  To: linux-ext4

https://bugzilla.kernel.org/show_bug.cgi?id=50021


Lukas Czerner <lczerner@redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lczerner@redhat.com




--- Comment #2 from Lukas Czerner <lczerner@redhat.com>  2012-11-05 13:58:09 ---
The discard in no-journal mode has been re-enabled with commit

b5e2368baeddf401bf3da9e364fc1c96676279cd ext4: re-enable -o discard
functionality in no-journal mode

so you probably have older kernel than that.

Thanks!
-Lukas

-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug 50021] ext4 discard option not working on journal dissabled filesystem
  2012-11-03 23:22 [Bug 50021] New: ext4 discard option not working on journal dissabled filesystem bugzilla-daemon
  2012-11-05 13:50 ` [Bug 50021] " bugzilla-daemon
  2012-11-05 13:58 ` bugzilla-daemon
@ 2012-11-05 14:13 ` bugzilla-daemon
  2012-11-05 17:35 ` bugzilla-daemon
  2012-11-05 18:00 ` bugzilla-daemon
  4 siblings, 0 replies; 6+ messages in thread
From: bugzilla-daemon @ 2012-11-05 14:13 UTC (permalink / raw)
  To: linux-ext4

https://bugzilla.kernel.org/show_bug.cgi?id=50021


Alan <alan@lxorguk.ukuu.org.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |alan@lxorguk.ukuu.org.uk
         Resolution|                            |CODE_FIX




-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug 50021] ext4 discard option not working on journal dissabled filesystem
  2012-11-03 23:22 [Bug 50021] New: ext4 discard option not working on journal dissabled filesystem bugzilla-daemon
                   ` (2 preceding siblings ...)
  2012-11-05 14:13 ` bugzilla-daemon
@ 2012-11-05 17:35 ` bugzilla-daemon
  2012-11-05 18:00 ` bugzilla-daemon
  4 siblings, 0 replies; 6+ messages in thread
From: bugzilla-daemon @ 2012-11-05 17:35 UTC (permalink / raw)
  To: linux-ext4

https://bugzilla.kernel.org/show_bug.cgi?id=50021


Theodore Tso <tytso@mit.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tytso@mit.edu




--- Comment #3 from Theodore Tso <tytso@mit.edu>  2012-11-05 17:35:08 ---
To be fair to the original reporter, this commit only hit the mainline kernel
in 3.7-rc1; given that he's running with a 3.6 kernel, he is running a pretty
up-to-date kernel.

Gregory, as Lukas pointed out, this functionality has been restored via commit
b5e2368baedd.  You should be able to cherry-pick this commit and apply it to
the 3.6 kernel without any difficulty, since it's a fairly straightforward
patch.

Regards,

-- Ted

-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Bug 50021] ext4 discard option not working on journal dissabled filesystem
  2012-11-03 23:22 [Bug 50021] New: ext4 discard option not working on journal dissabled filesystem bugzilla-daemon
                   ` (3 preceding siblings ...)
  2012-11-05 17:35 ` bugzilla-daemon
@ 2012-11-05 18:00 ` bugzilla-daemon
  4 siblings, 0 replies; 6+ messages in thread
From: bugzilla-daemon @ 2012-11-05 18:00 UTC (permalink / raw)
  To: linux-ext4

https://bugzilla.kernel.org/show_bug.cgi?id=50021





--- Comment #4 from Gregory Krzystek <ninex@o2.pl>  2012-11-05 18:00:08 ---
Thanks guys! :D
This patch works for me.

-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2012-11-05 18:00 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-11-03 23:22 [Bug 50021] New: ext4 discard option not working on journal dissabled filesystem bugzilla-daemon
2012-11-05 13:50 ` [Bug 50021] " bugzilla-daemon
2012-11-05 13:58 ` bugzilla-daemon
2012-11-05 14:13 ` bugzilla-daemon
2012-11-05 17:35 ` bugzilla-daemon
2012-11-05 18:00 ` bugzilla-daemon

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.