From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Widawsky Subject: Re: [PATCH 10/18] drm/i915: Support readback of stolen objects upon error Date: Mon, 5 Nov 2012 15:41:14 +0000 Message-ID: <20121105154114.3b620cd1@bwidawsk.net> References: <1350666204-8101-1-git-send-email-chris@chris-wilson.co.uk> <1350666204-8101-10-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from shiva.chad-versace.us (209-20-75-48.static.cloud-ips.com [209.20.75.48]) by gabe.freedesktop.org (Postfix) with ESMTP id C88A89E75F for ; Mon, 5 Nov 2012 07:40:50 -0800 (PST) In-Reply-To: <1350666204-8101-10-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Fri, 19 Oct 2012 18:03:16 +0100 Chris Wilson wrote: > Signed-off-by: Chris Wilson > Reviewed-by: Jesse Barnes > --- > drivers/gpu/drm/i915/i915_irq.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c > index d07c787..df3c10a 100644 > --- a/drivers/gpu/drm/i915/i915_irq.c > +++ b/drivers/gpu/drm/i915/i915_irq.c > @@ -924,6 +924,14 @@ i915_error_object_create(struct drm_i915_private *dev_priv, > reloc_offset); > memcpy_fromio(d, s, PAGE_SIZE); > io_mapping_unmap_atomic(s); > + } else if (src->stolen) { > + unsigned long offset; > + > + offset = dev_priv->mm.stolen_base; > + offset += src->stolen->start; > + offset += i << PAGE_SHIFT; > + > + memcpy_fromio(d, (void *)offset, PAGE_SIZE); > } else { > struct page *page; > void *s; Everything up to and including this is so far: Reviewed-by: Ben Widawsky -- Ben Widawsky, Intel Open Source Technology Center