From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1422930Ab2KNNpd (ORCPT ); Wed, 14 Nov 2012 08:45:33 -0500 Received: from cantor2.suse.de ([195.135.220.15]:47785 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1422757Ab2KNNpc (ORCPT ); Wed, 14 Nov 2012 08:45:32 -0500 Date: Wed, 14 Nov 2012 14:45:30 +0100 From: Michal Hocko To: David Rientjes Cc: Andrew Morton , KAMEZAWA Hiroyuki , KOSAKI Motohiro , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [patch 3/4] mm, oom: remove redundant sleep in pagefault oom handler Message-ID: <20121114134530.GC4929@dhcp22.suse.cz> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 14-11-12 01:15:25, David Rientjes wrote: > out_of_memory() will already cause current to schedule if it has not been > killed, so doing it again in pagefault_out_of_memory() is redundant. > Remove it. > > Cc: KAMEZAWA Hiroyuki > Cc: KOSAKI Motohiro > Cc: Michal Hocko > Signed-off-by: David Rientjes Reviewed-by: Michal Hocko > --- > mm/oom_kill.c | 1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/mm/oom_kill.c b/mm/oom_kill.c > --- a/mm/oom_kill.c > +++ b/mm/oom_kill.c > @@ -683,5 +683,4 @@ void pagefault_out_of_memory(void) > out_of_memory(NULL, 0, 0, NULL, false); > clear_zonelist_oom(zonelist, GFP_KERNEL); > } > - schedule_timeout_killable(1); > } -- Michal Hocko SUSE Labs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx176.postini.com [74.125.245.176]) by kanga.kvack.org (Postfix) with SMTP id 1909E6B0078 for ; Wed, 14 Nov 2012 08:45:33 -0500 (EST) Date: Wed, 14 Nov 2012 14:45:30 +0100 From: Michal Hocko Subject: Re: [patch 3/4] mm, oom: remove redundant sleep in pagefault oom handler Message-ID: <20121114134530.GC4929@dhcp22.suse.cz> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: owner-linux-mm@kvack.org List-ID: To: David Rientjes Cc: Andrew Morton , KAMEZAWA Hiroyuki , KOSAKI Motohiro , linux-kernel@vger.kernel.org, linux-mm@kvack.org On Wed 14-11-12 01:15:25, David Rientjes wrote: > out_of_memory() will already cause current to schedule if it has not been > killed, so doing it again in pagefault_out_of_memory() is redundant. > Remove it. > > Cc: KAMEZAWA Hiroyuki > Cc: KOSAKI Motohiro > Cc: Michal Hocko > Signed-off-by: David Rientjes Reviewed-by: Michal Hocko > --- > mm/oom_kill.c | 1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/mm/oom_kill.c b/mm/oom_kill.c > --- a/mm/oom_kill.c > +++ b/mm/oom_kill.c > @@ -683,5 +683,4 @@ void pagefault_out_of_memory(void) > out_of_memory(NULL, 0, 0, NULL, false); > clear_zonelist_oom(zonelist, GFP_KERNEL); > } > - schedule_timeout_killable(1); > } -- Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org