From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Ricardo Neri <ricardo.neri@ti.com>
Cc: lrg@ti.com, s-guiriec@ti.com, linux-omap@vger.kernel.org,
alsa-devel@alsa-project.org, "Valkeinen,
Tomi" <tomi.valkeinen@ti.com>
Subject: Re: [PATCH 3/3] ASoC: OMAP: HDMI: Obtain DMA port from resources
Date: Thu, 15 Nov 2012 08:08:55 +0900 [thread overview]
Message-ID: <20121114230848.GA4536@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <50A3CFBD.5080903@ti.com>
[-- Attachment #1: Type: text/plain, Size: 958 bytes --]
On Wed, Nov 14, 2012 at 11:07:09AM -0600, Ricardo Neri wrote:
> On 11/13/2012 09:27 PM, Mark Brown wrote:
> >Presumably this needs some other corresponding change in the resource
> >setup to go in simultaneously...
> Yes, the change in the resources setup has been submitted to the
> OMAPDSS HDMI driver and accepted by Tomi [1].
Don't do this. With a change like this which must be made at the same
time over multiple subsystems it is very important that you send all the
parts of the changes together. Otherwise there's a risk that one of
them won't get merged and even if they do both get merged you'll break
bisection - it's clear that nobody can be testing this on Tomi's branch.
> >>- hdmi_data->dma_params.port_addr = hdmi_rsrc->start
> >>- + OMAP_HDMI_AUDIO_DMA_PORT;
> >>+ hdmi_data->dma_params.port_addr = hdmi_rsrc->start;
> >...both before and after versions use the resource.
> This change should be present in K3.8.
What is "K3.8"?
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-11-14 23:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-14 2:30 [PATCH 0/3] Updated names for ASoC OMAP HDMI drivers Ricardo Neri
2012-11-14 2:30 ` [PATCH 1/3] ASoC: OMAP: HDMI: Update machine driver name Ricardo Neri
2012-11-14 10:16 ` Liam Girdwood
2012-11-14 17:00 ` Ricardo Neri
2012-11-14 2:30 ` [PATCH 2/3] ASoC: OMAP: HDMI: Update CPU DAI " Ricardo Neri
2012-11-14 2:30 ` [PATCH 3/3] ASoC: OMAP: HDMI: Obtain DMA port from resources Ricardo Neri
2012-11-14 3:27 ` Mark Brown
2012-11-14 17:07 ` Ricardo Neri
2012-11-14 23:08 ` Mark Brown [this message]
2012-11-15 2:33 ` Ricardo Neri
2012-11-15 4:10 ` Mark Brown
2012-11-15 16:22 ` Ricardo Neri
2012-11-15 9:45 ` Tomi Valkeinen
2012-11-15 12:36 ` Tomi Valkeinen
2012-11-16 1:39 ` Ricardo Neri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121114230848.GA4536@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=linux-omap@vger.kernel.org \
--cc=lrg@ti.com \
--cc=ricardo.neri@ti.com \
--cc=s-guiriec@ti.com \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.