From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [PATCH -next] tty: of_serial: fix return value check in of_platform_serial_setup() Date: Thu, 15 Nov 2012 17:22:32 -0800 Message-ID: <20121116012232.GB12364@kroah.com> References: <20121115120811.B9EB63E0B12@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20121115120811.B9EB63E0B12@localhost> Sender: linux-serial-owner@vger.kernel.org To: Grant Likely Cc: Wei Yongjun , alan@linux.intel.com, rob.herring@calxeda.com, seth.heasley@intel.com, stable@kernel.org, yongjun_wei@trendmicro.com.cn, linux-serial@vger.kernel.org, devicetree-discuss@lists.ozlabs.org List-Id: devicetree@vger.kernel.org On Thu, Nov 15, 2012 at 12:08:11PM +0000, Grant Likely wrote: > On Thu, 1 Nov 2012 13:27:34 +0800, Wei Yongjun wrote: > > From: Wei Yongjun > > > > In case of error, the function clk_get() returns ERR_PTR() > > and never returns NULL. The NULL test in the return value > > check should be replaced with IS_ERR(). > > > > dpatch engine is used to auto generate this patch. > > (https://github.com/weiyj/dpatch) > > > > Signed-off-by: Wei Yongjun > > Looks correct to me. > > Acked-by: Grant Likely > > Alan, which tree should this go through? My tty tree, I'll take it. thanks, greg k-h