Re: [PATCH v5] [media] vivi: Teach it to tune FPS

[Kirill Smelkov <kirr@mns.spb.ru>]

On Fri, Nov 16, 2012 at 03:51:23PM +0100, Hans Verkuil wrote:
> On Fri November 16 2012 15:48:41 Kirill Smelkov wrote:
> > On Fri, Nov 16, 2012 at 02:38:09PM +0100, Hans Verkuil wrote:
> > > On Wed November 7 2012 12:30:01 Kirill Smelkov wrote:
> > [...]
> > 
> > > > diff --git a/drivers/media/platform/vivi.c b/drivers/media/platform/vivi.c
> > > > index 37d0af8..5d1b374 100644
> > > > --- a/drivers/media/platform/vivi.c
> > > > +++ b/drivers/media/platform/vivi.c
> > > > @@ -65,8 +65,11 @@ MODULE_PARM_DESC(vid_limit, "capture memory limit in megabytes");
> > > >  /* Global font descriptor */
> > > >  static const u8 *font8x16;
> > > >  
> > > > -/* default to NTSC timeperframe */
> > > > -static const struct v4l2_fract TPF_DEFAULT = {.numerator = 1001, .denominator = 30000};
> > > > +/* timeperframe: min/max and default */
> > > > +static const struct v4l2_fract
> > > > +	tpf_min     = {.numerator = 1,		.denominator = UINT_MAX},  /* 1/infty */
> > > > +	tpf_max     = {.numerator = UINT_MAX,	.denominator = 1},         /* infty */
> > > 
> > > I understand your reasoning here, but I wouldn't go with UINT_MAX here. Something like
> > > 1/1000 tpf (or 1 ms) up to 86400/1 tpf (or once a day). With UINT_MAX I am afraid we
> > > might hit application errors when they manipulate these values. The shortest time
> > > between frames is 1 ms anyway.
> > > 
> > > It's the only comment I have, it looks good otherwise.
> > 
> > Thanks, Let's then merge it with 1/1000 - 1000/1 limit. Ok?
> 
> OK.

Thanks.