All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anton Vorontsov <cbouatmailru@gmail.com>
To: Haijun Zhang <Haijun.Zhang@freescale.com>
Cc: linux-mmc@vger.kernel.org, Jerry Huang <Chang-Ming.Huang@freescale.com>
Subject: Re: [PATCH 2/2] Powerpc/eSDHC: Add limit to data and erase timeout value calculation
Date: Sun, 18 Nov 2012 21:04:39 -0800	[thread overview]
Message-ID: <20121119050439.GA29095@lizard> (raw)
In-Reply-To: <1353296310-10786-2-git-send-email-Haijun.Zhang@freescale.com>

On Mon, Nov 19, 2012 at 11:38:29AM +0800, Haijun Zhang wrote:
> Some cards apply too larg timeout value for host to response,
> So limit the maximum data transfer timeout value and maximum erase
> timeout value to aviod timeout issue.
> 
> Signed-off-by: Haijun Zhang <Haijun.Zhang@freescale.com>
> Signed-off-by: Jerry Huang <Chang-Ming.Huang@freescale.com>
> Signed-off-by: Anton Vorontsov <cbouatmailru@gmail.com>

Ditto about the sign-off, it's inappropriate in this case.

[...]
> @@ -721,6 +722,10 @@ void mmc_set_data_timeout(struct mmc_data *data, const struct mmc_card *card)
>  				data->timeout_ns =  100000000;	/* 100ms */
>  		}
>  	}
> +
> +	if (host->max_discard_to &&
> +		host->max_discard_to < div_u64(data->timeout_ns, 1000000))

Still wrong indentation.

> +		data->timeout_ns = (u64)host->max_discard_to * 1000000;
>  }
>  EXPORT_SYMBOL(mmc_set_data_timeout);

  reply	other threads:[~2012-11-19  5:07 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-19  3:38 [PATCH] Powerpc eSDHC: Use u64 to calculate the timeout value to avoid overflow Haijun Zhang
2012-11-19  3:38 ` [PATCH 2/2] Powerpc/eSDHC: Add limit to data and erase timeout value calculation Haijun Zhang
2012-11-19  5:04   ` Anton Vorontsov [this message]
2012-11-19  5:23     ` Zhang Haijun-B42677
2012-11-19  5:33       ` Anton Vorontsov
2012-11-19  5:57         ` Zhang Haijun-B42677
2012-11-19  3:38 ` [PATCH 1/2 v2] Powerpc/eSDHC: Calculate the applicable mmc erase timeout value Haijun Zhang
2012-11-19  5:02 ` [PATCH] Powerpc eSDHC: Use u64 to calculate the timeout value to avoid overflow Anton Vorontsov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121119050439.GA29095@lizard \
    --to=cbouatmailru@gmail.com \
    --cc=Chang-Ming.Huang@freescale.com \
    --cc=Haijun.Zhang@freescale.com \
    --cc=linux-mmc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.