From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1757489Ab2KVULz (ORCPT <rfc822;w@1wt.eu>);
	Thu, 22 Nov 2012 15:11:55 -0500
Received: from mail-pa0-f46.google.com ([209.85.220.46]:39566 "EHLO
	mail-pa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1757456Ab2KVULx (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 22 Nov 2012 15:11:53 -0500
Date: Thu, 22 Nov 2012 12:08:41 -0800
From: Anton Vorontsov <anton.vorontsov@linaro.org>
To: "Rajanikanth H.V" <rajanikanth.hv@linaro.org>
Cc: rob.herring@calxeda.com, robherring2@gmail.com,
        francescolavra.fl@gmail.com, lee.jones@linaro.org, arnd@arndb.de,
        linus.walleij@stericsson.com, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org, linaro-dev@lists.linaro.org,
        patches@linaro.org, STEricsson_nomadik_linux@list.st.com,
        rajanikanth.hv@stericsson.com
Subject: Re: [PATCH 1/4] mfd: ab8500: add devicetree support for fuelgauge
Message-ID: <20121122200841.GB12397@lizard>
References: <1353609827-8218-1-git-send-email-rajanikanth.hv@linaro.org>
 <1353609827-8218-2-git-send-email-rajanikanth.hv@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <1353609827-8218-2-git-send-email-rajanikanth.hv@linaro.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Nov 23, 2012 at 12:13:44AM +0530, Rajanikanth H.V wrote:
[...]
> +/*
> + * Note that the batres_vs_temp table must be strictly sorted by falling
> + * temperature values to work.
> + */
> +struct batres_vs_temp temp_to_batres_tbl_thermistor[] = {

It must be static.

[..]
> +struct batres_vs_temp temp_to_batres_tbl_ext_thermistor[] = {

Ditto.

> +	{ 60, 300},
> +	{ 30, 300},
> +	{ 20, 300},
> +	{ 10, 300},
> +	{ 00, 300},
> +	{-10, 300},
> +	{-20, 300},
> +};
> +
> +/* battery resistance table for LI ION 9100 battery */
> +struct batres_vs_temp temp_to_batres_tbl_9100[] = {

Ditto.

There are other issues, which I fixed in my tree for the previous series.
So the previous series already merged, please post patches on top of it.

Thanks,
Anton.

From mboxrd@z Thu Jan  1 00:00:00 1970
From: anton.vorontsov@linaro.org (Anton Vorontsov)
Date: Thu, 22 Nov 2012 12:08:41 -0800
Subject: [PATCH 1/4] mfd: ab8500: add devicetree support for fuelgauge
In-Reply-To: <1353609827-8218-2-git-send-email-rajanikanth.hv@linaro.org>
References: <1353609827-8218-1-git-send-email-rajanikanth.hv@linaro.org>
 <1353609827-8218-2-git-send-email-rajanikanth.hv@linaro.org>
Message-ID: <20121122200841.GB12397@lizard>
To: linux-arm-kernel@lists.infradead.org
List-Id: linux-arm-kernel.lists.infradead.org

On Fri, Nov 23, 2012 at 12:13:44AM +0530, Rajanikanth H.V wrote:
[...]
> +/*
> + * Note that the batres_vs_temp table must be strictly sorted by falling
> + * temperature values to work.
> + */
> +struct batres_vs_temp temp_to_batres_tbl_thermistor[] = {

It must be static.

[..]
> +struct batres_vs_temp temp_to_batres_tbl_ext_thermistor[] = {

Ditto.

> +	{ 60, 300},
> +	{ 30, 300},
> +	{ 20, 300},
> +	{ 10, 300},
> +	{ 00, 300},
> +	{-10, 300},
> +	{-20, 300},
> +};
> +
> +/* battery resistance table for LI ION 9100 battery */
> +struct batres_vs_temp temp_to_batres_tbl_9100[] = {

Ditto.

There are other issues, which I fixed in my tree for the previous series.
So the previous series already merged, please post patches on top of it.

Thanks,
Anton.