Re: [PATCH 03/18] perf tools: Keep group information

From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Jiri Olsa <jolsa@redhat.com>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Stephane Eranian <eranian@google.com>,
	Andi Kleen <andi@firstfloor.org>,
	Namhyung Kim <namhyung.kim@lge.com>
Subject: Re: [PATCH 03/18] perf tools: Keep group information
Date: Thu, 29 Nov 2012 16:09:22 -0300	[thread overview]
Message-ID: <20121129190922.GD1957@ghostprotocols.net> (raw)
In-Reply-To: <1354201751.1630.45.camel@leonhard>

Em Fri, Nov 30, 2012 at 12:09:11AM +0900, Namhyung Kim escreveu:
> 2012-11-29 (목), 16:02 +0100, Jiri Olsa:
> > > You mean adding 'evsel->nr_members > 1' to this function?  For some
> > > reason, I'd like to treat non-group events as group leaders so I dropped
> > > that check from the function.
> > 
> > nope, the change is ok, I meant updating automated tests in tests/parse-events.c
> 
> Ah, okay.  Always forgot to update the test. :(  Will add.

Also consider adding more tests, perhaps for the formatting, i.e.
calling those hpp functions and then checking that the resulting
formatted string is the one expected.

One thing I need to do is to create a test that uses slang to write a
line with callchains and then, without updating the screen, check if
what is buffered to refresh the screen is what we expect, so that we can
check that that '+' char isn't lost like it happened twice :-)

- Arnaldo