From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Wed, 12 Dec 2012 06:16:41 -0700 Subject: [U-Boot] Pull request: u-boot-net.git master In-Reply-To: References: <593AEF6C47F46446852B067021A273D660C3348E@MUCSE039.lantiq.com> Message-ID: <20121212131641.GG32714@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Tue, Dec 11, 2012 at 09:42:21PM -0600, Joe Hershberger wrote: > Hi Thomas, > > On Tue, Dec 11, 2012 at 5:47 PM, Langer Thomas (LQDE RD ST PON SW) > wrote: > > Hello Joe, > > > > These patches for static initialization of the struct eth_ops will break the drivers on any architecture which needs manual relocation! > > > > I've send a comment regarding this, please see here: > > http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/146092/focus=147607 > > I missed that message before. Thanks for keeping an eye out! > > > The tests with QEMU are insufficient, as probably the memory locations before relocation were still available and used via the > > uncorrected pointers. > > I just ran into another issue on MIPS where the is the case... serial > is busted (serial_initialize() isn't called, which manually > relocates), but it doesn't appear as a crash because of the > pre-relocation addresses still being valid. > > > So please consider to revoke the pull request until an update with fixes for the "eth_ops" series is available. > > Indeed. Tom, please disregard this pull request. Disregarded. -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: