From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36216)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <philippe.mathieu.daude@gmail.com>)
	id 1fEdag-0002vs-U8
	for qemu-devel@nongnu.org; Fri, 04 May 2018 12:29:51 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <philippe.mathieu.daude@gmail.com>)
	id 1fEdad-0006cI-OF
	for qemu-devel@nongnu.org; Fri, 04 May 2018 12:29:50 -0400
Received: from mail-qk0-x243.google.com ([2607:f8b0:400d:c09::243]:42170)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <philippe.mathieu.daude@gmail.com>)
	id 1fEdad-0006bi-Fj
	for qemu-devel@nongnu.org; Fri, 04 May 2018 12:29:47 -0400
Received: by mail-qk0-x243.google.com with SMTP id j10so17052959qke.9
	for <qemu-devel@nongnu.org>; Fri, 04 May 2018 09:29:47 -0700 (PDT)
Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?=
	<philippe.mathieu.daude@gmail.com>
References: <1525376963-79623-1-git-send-email-mst@redhat.com>
	<1525376963-79623-4-git-send-email-mst@redhat.com>
From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= <f4bug@amsat.org>
Message-ID: <20126f54-4e12-1771-3765-e141b4baa848@amsat.org>
Date: Fri, 4 May 2018 13:29:43 -0300
MIME-Version: 1.0
In-Reply-To: <1525376963-79623-4-git-send-email-mst@redhat.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH 03/67] hppa: use local path for local
 headers
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, Richard Henderson <rth@twiddle.net>, peter.maydell@linaro.org

On 05/03/2018 04:50 PM, Michael S. Tsirkin wrote:
> When pulling in headers that are in the same directory as C file (as
> opposed to one in include/), we should use its relative path, without a
> directory. Directory based path works more or less by accident.
> 
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Tested-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

> ---
>  hw/hppa/hppa_sys.h | 2 +-
>  hw/hppa/machine.c  | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/hw/hppa/hppa_sys.h b/hw/hppa/hppa_sys.h
> index a182d1f..f98cc8d 100644
> --- a/hw/hppa/hppa_sys.h
> +++ b/hw/hppa/hppa_sys.h
> @@ -10,7 +10,7 @@
>  #include "hw/i386/pc.h"
>  #include "hw/irq.h"
>  
> -#include "hw/hppa/hppa_hardware.h"
> +#include "hppa_hardware.h"
>  
>  PCIBus *dino_init(MemoryRegion *, qemu_irq *, qemu_irq *);
>  
> diff --git a/hw/hppa/machine.c b/hw/hppa/machine.c
> index 19033e2..70f509b 100644
> --- a/hw/hppa/machine.c
> +++ b/hw/hppa/machine.c
> @@ -16,7 +16,7 @@
>  #include "hw/ide.h"
>  #include "hw/timer/i8254.h"
>  #include "hw/char/serial.h"
> -#include "hw/hppa/hppa_sys.h"
> +#include "hppa_sys.h"
>  #include "qemu/cutils.h"
>  #include "qapi/error.h"
>  #include "qemu/log.h"
>