All of lore.kernel.org
 help / color / mirror / Atom feed
From: Theodore Ts'o <tytso@mit.edu>
To: Andreas Dilger <adilger@dilger.ca>
Cc: Eric Sandeen <esandeen@redhat.com>,
	Ext4 Developers List <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH] mke2fs, tune2fs, resize2fs: add warning messages for bigalloc and quota
Date: Tue, 22 Jan 2013 13:45:53 -0500	[thread overview]
Message-ID: <20130122184553.GA14705@thunk.org> (raw)
In-Reply-To: <355F6D97-0481-45C8-805B-F2E2BF6118F8@dilger.ca>

On Tue, Jan 22, 2013 at 10:24:47AM -0700, Andreas Dilger wrote:
> 
> My preference would be to have separate "--force-bigalloc" and
> "--force-quota" options instead of lumping everything under a single
> "--force/-f" flag. That can become habitual for one kind of usage
> (e.g. mke2fs on a regular file) and then it also forces other
> dangerous behaviour (such as these) as an unknown side effect.

This would require us to figure out a backwards compatible way of
dealing with using getopt_long() for systems that don't have
getopt_long().  One of the things which I've been thinking about doing
in the 1.43 series is to rename libquota.a to libsupport.a, and then
moving e2fsck/profile.c and some of misc/util.c into libsupport.a.
Then we could optionally include the getopt_long() sources if we are
building on a system that doesn't have it.  This assumes that
getopt_long() is portable enough, and I don't know what kind of
dependencies it might drag in....

In the long term, I agree with you.

                                        - Ted


      parent reply	other threads:[~2013-01-22 18:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-22  0:09 [PATCH] mke2fs, tune2fs, resize2fs: add warning messages for bigalloc and quota Theodore Ts'o
2013-01-22  0:19 ` Eric Sandeen
2013-01-22 17:24   ` Andreas Dilger
2013-01-22 17:46     ` Eric Sandeen
2013-01-22 18:45     ` Theodore Ts'o [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130122184553.GA14705@thunk.org \
    --to=tytso@mit.edu \
    --cc=adilger@dilger.ca \
    --cc=esandeen@redhat.com \
    --cc=linux-ext4@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.