[PATCH] lib: devres: Fix build breakage

[PATCH] lib: devres: Fix build breakage

[Thierry Reding]

The ERR_PTR() and IS_ERR() macros used by the devm_ioremap_resource()
function are defined in the linux/err.h header. On ARM this seems to be
pulled in by one of the other headers but the build fails at least on
OpenRISC.

Signed-off-by: Thierry Reding <thierry.reding@avionic-design.de>
---
 lib/devres.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/devres.c b/lib/devres.c
index 9c76b3a..88ad759 100644
--- a/lib/devres.c
+++ b/lib/devres.c
@@ -1,3 +1,4 @@
+#include <linux/err.h>
 #include <linux/pci.h>
 #include <linux/io.h>
 #include <linux/gfp.h>
-- 
1.8.1.1

Re: [PATCH] lib: devres: Fix build breakage

[Greg Kroah-Hartman]

On Tue, Jan 22, 2013 at 10:24:46PM +0100, Thierry Reding wrote:
> The ERR_PTR() and IS_ERR() macros used by the devm_ioremap_resource()
> function are defined in the linux/err.h header. On ARM this seems to be
> pulled in by one of the other headers but the build fails at least on
> OpenRISC.
> 
> Signed-off-by: Thierry Reding <thierry.reding@avionic-design.de>

You forgot to put a "reported-by:" field in here, which I've now done
for you.  Please be more considerate in the future.

thanks,

greg k-h