From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754818Ab3AWKbb (ORCPT ); Wed, 23 Jan 2013 05:31:31 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:25371 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754390Ab3AWKba (ORCPT ); Wed, 23 Jan 2013 05:31:30 -0500 Date: Wed, 23 Jan 2013 13:31:08 +0300 From: Dan Carpenter To: Mark Einon Cc: davem@davemloft.net, gregkh@linuxfoundation.org, sfr@canb.auug.org.au, devel@driverdev.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH v2 linux-next] et131x: Promote staging et131x driver to drivers/net Message-ID: <20130123103108.GA4584@mwanda> References: <1358541648-29922-1-git-send-email-mark.einon@gmail.com> <1358935859-29525-1-git-send-email-mark.einon@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1358935859-29525-1-git-send-email-mark.einon@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: acsinet22.oracle.com [141.146.126.238] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 23, 2013 at 10:10:58AM +0000, Mark Einon wrote: > diff --git a/drivers/net/ethernet/agere/Kconfig b/drivers/net/ethernet/agere/Kconfig > new file mode 100644 > index 0000000..6854966 > --- /dev/null > +++ b/drivers/net/ethernet/agere/Kconfig > @@ -0,0 +1,32 @@ > +# > +# Agere device configuration > +# > + > +config NET_VENDOR_AGERE > + bool "Agere devices" > + default y > + depends on PCI > + ---help--- > + If you have a network (Ethernet) card belonging to this class, say Y > + and read the Ethernet-HOWTO, available from > + . > + > + Note that the answer to this question doesn't directly affect the > + kernel: saying N will just cause the configurator to skip all > + the questions about Atheros devices. If you say Y, you will be asked ^^^^^^^ Agere? > + for your specific card in the following questions. > + I think you should just leave this block out entirely. It doesn't save time for anyone. regards, dan carpenter