All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Mark Einon <mark.einon@gmail.com>
Cc: davem@davemloft.net, sfr@canb.auug.org.au,
	devel@driverdev.osuosl.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, dan.carpenter@oracle.com
Subject: Re: [RFC PATCH v3 linux-next] et131x: Promote staging et131x driver to drivers/net
Date: Wed, 23 Jan 2013 06:32:16 -0800	[thread overview]
Message-ID: <20130123143216.GA2050@kroah.com> (raw)
In-Reply-To: <1358945130-3101-1-git-send-email-mark.einon@gmail.com>

On Wed, Jan 23, 2013 at 12:45:30PM +0000, Mark Einon wrote:
> This patch moves the et131x gigabit ethernet driver from drivers/staging
> to drivers/net/ethernet/agere.
> 
> All the existing issues noted for this driver have been resolved, apart
> from one performance issue where some fragmented packets suffer from
> frame receive errors.
> 
> Signed-off-by: Mark Einon <mark.einon@gmail.com>
> ---
> 
> Changes from V2 - vendor name changed from Atheros to Agere in drivers/net/ethernet/agere/Kconfig
> 
>  MAINTAINERS                                        |   11 ++++---
>  drivers/net/ethernet/Kconfig                       |    1 +
>  drivers/net/ethernet/Makefile                      |    1 +
>  drivers/net/ethernet/agere/Kconfig                 |   32 ++++++++++++++++++++
>  .../et131x => net/ethernet/agere}/Makefile         |    1 +
>  .../et131x => net/ethernet/agere}/et131x.c         |    0
>  .../et131x => net/ethernet/agere}/et131x.h         |    0
>  drivers/staging/Kconfig                            |    2 --
>  drivers/staging/Makefile                           |    1 -
>  drivers/staging/et131x/Kconfig                     |   10 ------
>  drivers/staging/et131x/README                      |   16 ----------
>  11 files changed, 41 insertions(+), 34 deletions(-)
>  create mode 100644 drivers/net/ethernet/agere/Kconfig
>  rename drivers/{staging/et131x => net/ethernet/agere}/Makefile (98%)
>  rename drivers/{staging/et131x => net/ethernet/agere}/et131x.c (100%)
>  rename drivers/{staging/et131x => net/ethernet/agere}/et131x.h (100%)
>  delete mode 100644 drivers/staging/et131x/Kconfig
>  delete mode 100644 drivers/staging/et131x/README

Creating a patch this way is the correct way to do it, however it gives
no clue to the network developers as to exactly what is in this driver
at the moment :(

I usually recommend just creating a new patch, that adds the driver to
the proper place in the kernel, and sending that in.  If the subsystem
maintainers accept it, then I can just delete the staging driver.

Yes, this looses the history of the code, but usually no one cares about
that for staging drivers.

If that's not ok, I have no problem accepting this, if I get an ack from
the subsystem maintainers that it's ok, but again, this patch makes it
pretty hard for them to know that or not.

thanks,

greg k-h

  reply	other threads:[~2013-01-23 14:30 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-18 20:40 [RFC PATCH linux-next] et131x: Promote staging et131x driver to drivers/net Mark Einon
2013-01-18 22:57 ` Greg KH
2013-01-19 11:03   ` Dan Carpenter
2013-01-19 11:48     ` [PATCH] staging: et131x: Fix all sparse warnings Mark Einon
2013-01-21 23:44     ` [RFC PATCH linux-next] et131x: Promote staging et131x driver to drivers/net Mark Einon
2013-01-22  6:20       ` Dan Carpenter
2013-01-23 10:10 ` [RFC PATCH v2 " Mark Einon
2013-01-23 10:31   ` Dan Carpenter
2013-01-23 11:31     ` Mark Einon
2013-01-23 12:45   ` [RFC PATCH v3 " Mark Einon
2013-01-23 14:32     ` Greg KH [this message]
2013-01-23 14:51       ` Mark Einon
2013-01-23 16:24     ` [RFC PATCH v4 " Mark Einon
2013-01-29  4:10       ` David Miller
2013-01-29 12:47         ` Mark Einon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130123143216.GA2050@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=dan.carpenter@oracle.com \
    --cc=davem@davemloft.net \
    --cc=devel@driverdev.osuosl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.einon@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.