Hi Denis,

On 14:34 Wed 23 Jan, Denis Kenzior wrote:
> Hi Vinicius,
> 
> >diff --git a/plugins/phonesim.c b/plugins/phonesim.c
> >index 26f96d0..9210e02 100644
> >--- a/plugins/phonesim.c
> >+++ b/plugins/phonesim.c
> >@@ -929,8 +929,8 @@ static int localhfp_enable(struct ofono_modem *modem)
> >
> >  	g_at_chat_set_disconnect_function(chat, slc_failed, modem);
> >
> >-	hfp_slc_info_init(info, HFP_VERSION_LATEST);
> >-	info->chat = chat;
> >+	info = hfp_slc_info_init(chat, HFP_VERSION_LATEST);
> >+	g_at_chat_unref(chat);
> >  	hfp_slc_establish(info, slc_established, slc_failed, modem);
> >
> >  	return -EINPROGRESS;
> 
> This part makes no sense.  I refer you to localhfp_probe() function.
> Are you testing any of your changes?

Ugh. That is what happens when you mess with code that you are not familiar
with, and do not properly test it.

Will send a new version of the remaining of the series, without any changes
related to the allocation of hfp_slc_info. So we delay having to deal with
allocating it until we really need it. And we do not touch code that we
are not sure how it works.

> 
> Regards,
> -Denis


Cheers,
-- 
Vinicius