From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [PATCH]: PVH: specify xen features strings cleany for PVH Date: Thu, 24 Jan 2013 10:10:15 -0500 Message-ID: <20130124151015.GB5448@konrad-lan.dumpdata.com> References: <20130118173503.71de0603@mantra.us.oracle.com> <50FD3D6202000078000B7CE4@nat28.tlf.novell.com> <20130122151241.7ed034f4@mantra.us.oracle.com> <50FFABE702000078000B88E1@nat28.tlf.novell.com> <20130123144347.78ba0a3f@mantra.us.oracle.com> <51010A1802000078000B9027@nat28.tlf.novell.com> <1359019625.17440.70.camel@zakaz.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1359019625.17440.70.camel@zakaz.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: Jan Beulich , xen-devel List-Id: xen-devel@lists.xenproject.org On Thu, Jan 24, 2013 at 09:27:05AM +0000, Ian Campbell wrote: > On Thu, 2013-01-24 at 09:16 +0000, Jan Beulich wrote: > > This looks to be an incremental patch on top of something I > > don't think I've seen - there's neither an embedded \0 nor any > > redundancy being removed here, yet I'm sure that was so in the > > prior patch, and these two were what I disliked most. So perhaps > > sending out the original patch this one goes on top of was simply > > never done? > > The baseline of this patch wouldn't have worked because it has .asciz as > the first (global) features, so that would be NULL terminated and the > PVH features wouldn't appear. > > This one one of the first revisions I think it's probably what is > current in Konrad's tree. Yup. > > Ian. >