From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753944Ab3AYJUl (ORCPT ); Fri, 25 Jan 2013 04:20:41 -0500 Received: from mail-ee0-f51.google.com ([74.125.83.51]:37052 "EHLO mail-ee0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753306Ab3AYJUh (ORCPT ); Fri, 25 Jan 2013 04:20:37 -0500 Date: Fri, 25 Jan 2013 10:20:32 +0100 From: Ingo Molnar To: Borislav Petkov , "H. Peter Anvin" , X86 ML , Greg Kroah-Hartman , LKML , devel@linuxdriverproject.org, olaf@aepfle.de, apw@canonical.com, jasowang@redhat.com, Thomas Gleixner , JBeulich@suse.com, Borislav Petkov Subject: Re: [PATCH 1/2] x86, Kconfig: Move PARAVIRT_DEBUG into the paravirt menu Message-ID: <20130125092032.GC31478@gmail.com> References: <20130124173555.GJ13463@pd.tnic> <1359049194-17505-1-git-send-email-bp@alien8.de> <20130125082126.GD25314@gmail.com> <20130125085146.GA23404@pd.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130125085146.GA23404@pd.tnic> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Borislav Petkov wrote: > On Fri, Jan 25, 2013 at 09:21:26AM +0100, Ingo Molnar wrote: > > > > So, these two patches, on top of -tip, produce: > > > > vmw_balloon.c:(.init.text+0x8506): undefined reference to `x86_hyper' > > vmw_balloon.c:(.init.text+0x850a): undefined reference to `x86_hyper_vmware' > > Hmm, I somehow can't trigger it here. And the thing is, vmw_balloon.c is > built only when CONFIG_VMWARE_BALLOON is set and that is not the case in > this config. > > [ ??? ] Maybe it's related, but I had to resolve two conflicts when merging your two patches to tip:x86/cpu and then to tip:master - first in arch/x86/Kconfig, then in arch/x86/include/asm/hypervisor.h. The second conflict looked harmless, due to: 4cca6ea04d31 x86/apic: Allow x2apic without IR on VMware platform Thanks, Ingo