All of lore.kernel.org
 help / color / mirror / Atom feed
From: Borislav Petkov <bp@alien8.de>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@kernel.org>,
	X86 ML <x86@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	LKML <linux-kernel@vger.kernel.org>,
	devel@linuxdriverproject.org, olaf@aepfle.de, apw@canonical.com,
	jasowang@redhat.com, Thomas Gleixner <tglx@linutronix.de>,
	JBeulich@suse.com, Borislav Petkov <bp@suse.de>,
	Dmitry Torokhov <dtor@vmware.com>,
	"K. Y. Srinivasan" <kys@microsoft.com>,
	Haiyang Zhang <haiyangz@microsoft.com>
Subject: Re: [PATCH -v2 2/2] x86: Make Linux guest support optional
Date: Fri, 25 Jan 2013 19:32:13 +0100	[thread overview]
Message-ID: <20130125183213.GB1380@pd.tnic> (raw)
In-Reply-To: <20130125181251.GA5563@core.coreip.homeip.net>

On Fri, Jan 25, 2013 at 10:12:51AM -0800, Dmitry Torokhov wrote:
> Hi Borislav,
> 
> On Fri, Jan 25, 2013 at 06:59:37PM +0100, Borislav Petkov wrote:
> > From: Borislav Petkov <bp@suse.de>
> > 
> > Put all config options needed to run Linux as a guest behind a
> > CONFIG_HYPERVISOR_GUEST menu so that they don't get built-in by
> > default but selected by the user. Also, move x86_hyper into an
> > unconditionally-built compilation unit because it is exported with the
> > non-GPL flavour and we can't know whatever uses it on the outside.
> 
> I am confused by this statement... How can EXPORT_SYMBOL() vs
> EXPORT_SYMBOL_GPL() help you determining if it is used out of tree or
> not?

Maybe this wasn't formulated clear enough - I wanted to say that with
the !GPL flavor, any code (proprietary included) can link to those
symbols and we cannot know who uses it and if we hide that symbol,
someone would probably come crying.

Because if we could, I would've done trivial accessor functions which
would return NULL when CONFIG_HYPERVISOR_GUEST is not set so that those
cases build and boot fine, and we wouldn't have the need to have this
symbol always present (like is the case now and I had to move it to
setup.c).

If it were _GPL, we would've fixed all its users to switch to the
accessors.

Makes more sense?

-- 
Regards/Gruss,
    Boris.

Sent from a fat crate under my desk. Formatting is fine.
--

  reply	other threads:[~2013-01-25 18:29 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-24  1:56 [PATCH RESEND 1/1] X86: Handle Hyper-V vmbus interrupts as special hypervisor interrupts K. Y. Srinivasan
2013-01-24  9:28 ` Borislav Petkov
2013-01-24 12:11   ` H. Peter Anvin
2013-01-24 17:35     ` Borislav Petkov
2013-01-24 17:36       ` H. Peter Anvin
2013-01-24 17:39       ` [PATCH 1/2] x86, Kconfig: Move PARAVIRT_DEBUG into the paravirt menu Borislav Petkov
2013-01-24 17:39         ` [PATCH 2/2] x86: Make Linux guest support optional Borislav Petkov
2013-01-25  8:21         ` [PATCH 1/2] x86, Kconfig: Move PARAVIRT_DEBUG into the paravirt menu Ingo Molnar
2013-01-25  8:51           ` Borislav Petkov
2013-01-25  9:20             ` Ingo Molnar
2013-01-25  9:29               ` Borislav Petkov
2013-01-25  9:32                 ` Ingo Molnar
2013-01-25 10:06                   ` Borislav Petkov
2013-01-25 17:59                     ` [PATCH -v2 " Borislav Petkov
2013-01-25 17:59                     ` [PATCH -v2 2/2] x86: Make Linux guest support optional Borislav Petkov
2013-01-25 18:07                       ` Dmitry Torokhov
2013-01-25 18:23                         ` Borislav Petkov
2013-01-25 18:29                           ` Dmitry Torokhov
2013-01-25 18:35                             ` Borislav Petkov
2013-01-25 18:43                               ` Borislav Petkov
2013-01-27  1:26                                 ` H. Peter Anvin
2013-01-27 10:30                                   ` Borislav Petkov
2013-01-25 18:12                       ` Dmitry Torokhov
2013-01-25 18:32                         ` Borislav Petkov [this message]
2013-01-25 18:42                           ` Dmitry Torokhov
2013-01-25 19:03                             ` Borislav Petkov
2013-01-26 23:10                               ` [PATCH -v3 1/2] x86, Kconfig: Move PARAVIRT_DEBUG into the paravirt menu Borislav Petkov
2013-01-26 23:10                               ` [PATCH -v3 2/2] x86: Make Linux guest support optional Borislav Petkov
2013-01-27 11:06                                 ` Borislav Petkov
2013-01-28 10:18                                   ` [PATCH -v3.1] " Borislav Petkov
2013-01-24 17:42   ` [PATCH RESEND 1/1] X86: Handle Hyper-V vmbus interrupts as special hypervisor interrupts KY Srinivasan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130125183213.GB1380@pd.tnic \
    --to=bp@alien8.de \
    --cc=JBeulich@suse.com \
    --cc=apw@canonical.com \
    --cc=bp@suse.de \
    --cc=devel@linuxdriverproject.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=dtor@vmware.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=haiyangz@microsoft.com \
    --cc=hpa@zytor.com \
    --cc=jasowang@redhat.com \
    --cc=kys@microsoft.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=olaf@aepfle.de \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.