From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mukesh Rathor Subject: Re: Is: PVH + ARM new hypercalls. Was: Re: [PATCH]: PVH: specify xen features strings cleany for PVH Date: Mon, 28 Jan 2013 18:57:37 -0800 Message-ID: <20130128185737.55ec65f8@mantra.us.oracle.com> References: <50FD3D6202000078000B7CE4@nat28.tlf.novell.com> <20130122151241.7ed034f4@mantra.us.oracle.com> <50FFABE702000078000B88E1@nat28.tlf.novell.com> <20130123144347.78ba0a3f@mantra.us.oracle.com> <51010A1802000078000B9027@nat28.tlf.novell.com> <20130124151336.311c3456@mantra.us.oracle.com> <51024A2602000078000B9786@nat28.tlf.novell.com> <1359108703.10051.5.camel@zakaz.uk.xensource.com> <51026C3602000078000B9911@nat28.tlf.novell.com> <1359110621.10051.25.camel@zakaz.uk.xensource.com> <20130128162607.GA7223@konrad-lan.dumpdata.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20130128162607.GA7223@konrad-lan.dumpdata.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Konrad Rzeszutek Wilk Cc: Konrad Rzeszutek Wilk , Ian Campbell , Jan Beulich , xen-devel List-Id: xen-devel@lists.xenproject.org On Mon, 28 Jan 2013 11:26:08 -0500 Konrad Rzeszutek Wilk wrote: > On Fri, Jan 25, 2013 at 10:43:41AM +0000, Ian Campbell wrote: > > On Fri, 2013-01-25 at 10:27 +0000, Jan Beulich wrote: > > #define PHYSDEVOP_map_iomem 30 > struct physdev_map_iomem { > /* IN */ > uint64_t first_gfn; > uint64_t first_mfn; > uint32_t nr_mfns; > uint32_t add_mapping; /* 1 == add mapping; 0 == unmap */ > > }; Since the new recommendation is to map transparently, we don't need this anymore. I'll submit an incremental patch to you Konrad. > and the modification to one: > > commit 50c0b3df91be7a440b50ee7d74fd2042bca173fd > Author: Mukesh Rathor > Date: Mon Oct 22 11:37:57 2012 -0400 > > xen/pvh: Extend vcpu_guest_context, p2m, event, and XenBus. > > Make gdt_frames[]/gdt_ents into a union with {gdtaddr, gdtsz}, > as PVH only needs to send down gdtaddr and gdtsz in the > vcpu_guest_context structure.. > > For interrupts, PVH uses native_irq_ops so we can skip most of the > PV ones. In the future we can support the pirq_eoi_map.. > Also VCPU hotplug is currently not available for PVH. > > For events (and IRQs) we follow what PVHVM does - so use callback > vector. Lastly, for XenBus we use the same logic that is used in > the PVHVM case. > > Acked-by: Stefano Stabellini > Signed-off-by: Mukesh Rathor > [v2: Rebased it] > [v3: Move 64-bit ifdef and based on Stefan add extra comments.] > [v4: Rebased it once more] > Signed-off-by: Konrad Rzeszutek Wilk > > diff --git a/arch/x86/include/asm/xen/interface.h > b/arch/x86/include/asm/xen/interface.h index fd9cb76..20e738a 100644 > --- a/arch/x86/include/asm/xen/interface.h > +++ b/arch/x86/include/asm/xen/interface.h > @@ -145,7 +145,16 @@ struct vcpu_guest_context { > struct cpu_user_regs user_regs; /* User-level CPU > registers */ struct trap_info trap_ctxt[256]; /* Virtual > IDT */ unsigned long ldt_base, ldt_ents; /* > LDT (linear address, # ents) */ > - unsigned long gdt_frames[16], gdt_ents; /* GDT (machine frames, > # ents) */ > + union { > + struct { > + /* PV: GDT (machine frames, # ents).*/ > + unsigned long gdt_frames[16], gdt_ents; > + } pv; > + struct { > + /* PVH: GDTR addr and size */ > + unsigned long gdtaddr, gdtsz; > + } pvh; > + } u; > unsigned long kernel_ss, kernel_sp; /* Virtual TSS (only On xen side I added the ifdef: #if __XEN_INTERFACE_VERSION__ < 0x00040300 unsigned long gdt_frames[16], gdt_ents; /* GDT (machine frames, # ents) */ #else union { struct { /* GDT (machine frames, # ents) */ unsigned long gdt_frames[16], gdt_ents; } pv; struct { /* PVH: GDTR addr and size */ unsigned long gdtaddr, gdtsz; } pvh; } u; #endif but it doesn't matter on linux side, so up to you.