From mboxrd@z Thu Jan  1 00:00:00 1970
From: Amit Shah <amit.shah@redhat.com>
Subject: Re: [PATCH] virtio_console: Don't access uninitialized data.
Date: Mon, 4 Feb 2013 12:02:51 +0530
Message-ID: <20130204063251.GB32509@amit.redhat.com>
References: <1358425292-4449-1-git-send-email-sjur.brandeland@stericsson.com>
	<20130125090801.GA30483@amit.redhat.com>
	<87vca9klwm.fsf@rustcorp.com.au>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <virtualization-bounces@lists.linux-foundation.org>
Content-Disposition: inline
In-Reply-To: <87vca9klwm.fsf@rustcorp.com.au>
List-Unsubscribe: <https://lists.linuxfoundation.org/mailman/options/virtualization>,
	<mailto:virtualization-request@lists.linux-foundation.org?subject=unsubscribe>
List-Archive: <http://lists.linuxfoundation.org/pipermail/virtualization/>
List-Post: <mailto:virtualization@lists.linux-foundation.org>
List-Help: <mailto:virtualization-request@lists.linux-foundation.org?subject=help>
List-Subscribe: <https://lists.linuxfoundation.org/mailman/listinfo/virtualization>,
	<mailto:virtualization-request@lists.linux-foundation.org?subject=subscribe>
Sender: virtualization-bounces@lists.linux-foundation.org
Errors-To: virtualization-bounces@lists.linux-foundation.org
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: "Michael S. Tsirkin" <mst@redhat.com>, virtualization@lists.linux-foundation.org, sjur.brandeland@stericsson.com
List-Id: virtualization@lists.linuxfoundation.org

On (Mon) 04 Feb 2013 [10:09:05], Rusty Russell wrote:
> Amit Shah <amit.shah@redhat.com> writes:
> > On (Thu) 17 Jan 2013 [13:21:32], sjur.brandeland@stericsson.com wrote:
> >> From: Sjur Br=E6ndeland <sjur.brandeland@stericsson.com>
> >> =

> >> Don't access uninitialized work-queue when removing device.
> >> The work queue is initialized only if the device multi-queue.
> >> So don't call cancel_work unless this is a multi-queue device.
> >> =

> >> This fixes the following panic:
> >
> > [snip]
> >
> >> Signed-off-by: Sjur Br=E6ndeland <sjur.brandeland@stericsson.com>
> >
> > Acked-by: Amit Shah <amit.shah@redhat.com>
> >
> >> This fix is intended of v3.8.
> >
> > Should also be CC'ed to stable@
> =

> Sorry, I was at linux.conf.au all last week.
> =

> I've already sent it to Linus.  Sjur said: "This fix is intended of
> v3.8.".  If it needs to be in -stable, please tell me and I'll fwd it
> manually.

This can result in a panic when removing the device or module (when
not using multiport).  I'd vote for submitting to stable.

		Amit