From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754122Ab3BEL2I (ORCPT ); Tue, 5 Feb 2013 06:28:08 -0500 Received: from caramon.arm.linux.org.uk ([78.32.30.218]:35587 "EHLO caramon.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753814Ab3BEL2C (ORCPT ); Tue, 5 Feb 2013 06:28:02 -0500 Date: Tue, 5 Feb 2013 11:27:31 +0000 From: Russell King - ARM Linux To: "Vishwanathrao Badarkhe, Manish" Cc: Tony Lindgren , Linus Walleij , "davinci-linux-open-source@linux.davincidsp.com" , "sameo@linux.intel.com" , "linux-doc@vger.kernel.org" , "khilman@deeprootsystems.com" , "devicetree-discuss@lists.ozlabs.org" , "broonie@opensource.wolfsonmicro.com" , "Nori, Sekhar" , "linux-kernel@vger.kernel.org" , "rob.herring@calxeda.com" , "hs@denx.de" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH V2 1/6] pinctrl: pinctrl-single: use arch_initcall and module_exit Message-ID: <20130205112731.GK17786@n2100.arm.linux.org.uk> References: <1359445134-13323-1-git-send-email-manishv.b@ti.com> <1359445134-13323-2-git-send-email-manishv.b@ti.com> <20130201170906.GE22517@atomide.com> <20130201171124.GF22517@atomide.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.19 (2009-01-05) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 05, 2013 at 06:36:34AM +0000, Vishwanathrao Badarkhe, Manish wrote: > I made following changes, in order to update "dip->p" pointer with > correct value: > > - if (!dpi->p) { > + if (IS_ERR_OR_NULL(dpi->p)) { > dpi->p = devm_pinctrl_get(dev); > - if (IS_ERR_OR_NULL(dpi->p)) { > - int ret = PTR_ERR(dpi->p); > - > - dev_dbg(dev, "no pinctrl handle\n"); > - /* Only return deferrals */ > - if (ret == -EPROBE_DEFER) > - return ret; > - return 0; > - } > + ret = PTR_ERR(dpi->p); > + dev_dbg(dev, "no pinctrl handle\n"); > + /* Only return deferrals */ > + if (ret == -EPROBE_DEFER) > + return ret; > + return 0; > > Is this intended change? The above looks totally broken to me. Oh, it's using IS_ERR_OR_NULL(), so it's bound to be broken. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Russell King - ARM Linux Subject: Re: [PATCH V2 1/6] pinctrl: pinctrl-single: use arch_initcall and module_exit Date: Tue, 5 Feb 2013 11:27:31 +0000 Message-ID: <20130205112731.GK17786@n2100.arm.linux.org.uk> References: <1359445134-13323-1-git-send-email-manishv.b@ti.com> <1359445134-13323-2-git-send-email-manishv.b@ti.com> <20130201170906.GE22517@atomide.com> <20130201171124.GF22517@atomide.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-doc-owner@vger.kernel.org To: "Vishwanathrao Badarkhe, Manish" Cc: Tony Lindgren , Linus Walleij , "davinci-linux-open-source@linux.davincidsp.com" , "sameo@linux.intel.com" , "linux-doc@vger.kernel.org" , "khilman@deeprootsystems.com" , "devicetree-discuss@lists.ozlabs.org" , "broonie@opensource.wolfsonmicro.com" , "Nori, Sekhar" , "linux-kernel@vger.kernel.org" , "rob.herring@calxeda.com" , "hs@denx.de" , "linux-arm-kernel@lists.infradead.org" List-Id: devicetree@vger.kernel.org On Tue, Feb 05, 2013 at 06:36:34AM +0000, Vishwanathrao Badarkhe, Manish wrote: > I made following changes, in order to update "dip->p" pointer with > correct value: > > - if (!dpi->p) { > + if (IS_ERR_OR_NULL(dpi->p)) { > dpi->p = devm_pinctrl_get(dev); > - if (IS_ERR_OR_NULL(dpi->p)) { > - int ret = PTR_ERR(dpi->p); > - > - dev_dbg(dev, "no pinctrl handle\n"); > - /* Only return deferrals */ > - if (ret == -EPROBE_DEFER) > - return ret; > - return 0; > - } > + ret = PTR_ERR(dpi->p); > + dev_dbg(dev, "no pinctrl handle\n"); > + /* Only return deferrals */ > + if (ret == -EPROBE_DEFER) > + return ret; > + return 0; > > Is this intended change? The above looks totally broken to me. Oh, it's using IS_ERR_OR_NULL(), so it's bound to be broken. From mboxrd@z Thu Jan 1 00:00:00 1970 From: linux@arm.linux.org.uk (Russell King - ARM Linux) Date: Tue, 5 Feb 2013 11:27:31 +0000 Subject: [PATCH V2 1/6] pinctrl: pinctrl-single: use arch_initcall and module_exit In-Reply-To: References: <1359445134-13323-1-git-send-email-manishv.b@ti.com> <1359445134-13323-2-git-send-email-manishv.b@ti.com> <20130201170906.GE22517@atomide.com> <20130201171124.GF22517@atomide.com> Message-ID: <20130205112731.GK17786@n2100.arm.linux.org.uk> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Feb 05, 2013 at 06:36:34AM +0000, Vishwanathrao Badarkhe, Manish wrote: > I made following changes, in order to update "dip->p" pointer with > correct value: > > - if (!dpi->p) { > + if (IS_ERR_OR_NULL(dpi->p)) { > dpi->p = devm_pinctrl_get(dev); > - if (IS_ERR_OR_NULL(dpi->p)) { > - int ret = PTR_ERR(dpi->p); > - > - dev_dbg(dev, "no pinctrl handle\n"); > - /* Only return deferrals */ > - if (ret == -EPROBE_DEFER) > - return ret; > - return 0; > - } > + ret = PTR_ERR(dpi->p); > + dev_dbg(dev, "no pinctrl handle\n"); > + /* Only return deferrals */ > + if (ret == -EPROBE_DEFER) > + return ret; > + return 0; > > Is this intended change? The above looks totally broken to me. Oh, it's using IS_ERR_OR_NULL(), so it's bound to be broken.