From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: Latest additional build warnings Date: Tue, 5 Feb 2013 09:51:26 -0800 Message-ID: <20130205175126.GH25185@atomide.com> References: <20130205142218.GB17833@n2100.arm.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mho-04-ewr.mailhop.org ([204.13.248.74]:34473 "EHLO mho-02-ewr.mailhop.org" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754018Ab3BERvd (ORCPT ); Tue, 5 Feb 2013 12:51:33 -0500 Content-Disposition: inline In-Reply-To: <20130205142218.GB17833@n2100.arm.linux.org.uk> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Arnd Bergmann , Olof Johansson Cc: linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, arm@kernel.org, Russell King - ARM Linux * Russell King - ARM Linux [130205 06:25]: > arch/arm/mach-omap2/hwspinlock.c:60:1: warning: data definition has no type or storage class > arch/arm/mach-omap2/hwspinlock.c:60:1: warning: type defaults to 'int' in declaration of 'omap_postcore_initcall' > arch/arm/mach-omap2/hwspinlock.c:60:1: warning: parameter names (without types) in function declaration > arch/arm/mach-omap2/hwspinlock.c:31:122: warning: 'hwspinlocks_init' defined but not used Thanks looks like I missed that one somehow. Here's a fix for it. Arnd & Olof, care to apply this directly into the arm-soc multiplatform branch? Regards, Tony From: Tony Lindgren Date: Tue, 5 Feb 2013 09:48:08 -0800 Subject: [PATCH] ARM: OMAP2+: Fix warning for hwspinlock omap_postcore_initcall Commit 816a65ef4 (ARM: OMAP2+: Limit omap initcalls to omap only on multiplatform kernels) fixed up things for multiplatform booting but failed to include soc.h causing a new warning: arch/arm/mach-omap2/hwspinlock.c:60:1: warning: data definition has no type or storage class arch/arm/mach-omap2/hwspinlock.c:60:1: warning: type defaults to 'int' in declaration of 'omap_postcore_initcall' arch/arm/mach-omap2/hwspinlock.c:60:1: warning: parameter names (without types) in function declaration arch/arm/mach-omap2/hwspinlock.c:31:122: warning: 'hwspinlocks_init' defined but not used Reported-by: Signed-off-by: Russell King Signed-off-by: Tony Lindgren diff --git a/arch/arm/mach-omap2/hwspinlock.c b/arch/arm/mach-omap2/hwspinlock.c index ce1b5b6..bcb357e 100644 --- a/arch/arm/mach-omap2/hwspinlock.c +++ b/arch/arm/mach-omap2/hwspinlock.c @@ -21,6 +21,7 @@ #include #include +#include "soc.h" #include "omap_hwmod.h" #include "omap_device.h" From mboxrd@z Thu Jan 1 00:00:00 1970 From: tony@atomide.com (Tony Lindgren) Date: Tue, 5 Feb 2013 09:51:26 -0800 Subject: Latest additional build warnings In-Reply-To: <20130205142218.GB17833@n2100.arm.linux.org.uk> References: <20130205142218.GB17833@n2100.arm.linux.org.uk> Message-ID: <20130205175126.GH25185@atomide.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org * Russell King - ARM Linux [130205 06:25]: > arch/arm/mach-omap2/hwspinlock.c:60:1: warning: data definition has no type or storage class > arch/arm/mach-omap2/hwspinlock.c:60:1: warning: type defaults to 'int' in declaration of 'omap_postcore_initcall' > arch/arm/mach-omap2/hwspinlock.c:60:1: warning: parameter names (without types) in function declaration > arch/arm/mach-omap2/hwspinlock.c:31:122: warning: 'hwspinlocks_init' defined but not used Thanks looks like I missed that one somehow. Here's a fix for it. Arnd & Olof, care to apply this directly into the arm-soc multiplatform branch? Regards, Tony From: Tony Lindgren Date: Tue, 5 Feb 2013 09:48:08 -0800 Subject: [PATCH] ARM: OMAP2+: Fix warning for hwspinlock omap_postcore_initcall Commit 816a65ef4 (ARM: OMAP2+: Limit omap initcalls to omap only on multiplatform kernels) fixed up things for multiplatform booting but failed to include soc.h causing a new warning: arch/arm/mach-omap2/hwspinlock.c:60:1: warning: data definition has no type or storage class arch/arm/mach-omap2/hwspinlock.c:60:1: warning: type defaults to 'int' in declaration of 'omap_postcore_initcall' arch/arm/mach-omap2/hwspinlock.c:60:1: warning: parameter names (without types) in function declaration arch/arm/mach-omap2/hwspinlock.c:31:122: warning: 'hwspinlocks_init' defined but not used Reported-by: Signed-off-by: Russell King Signed-off-by: Tony Lindgren diff --git a/arch/arm/mach-omap2/hwspinlock.c b/arch/arm/mach-omap2/hwspinlock.c index ce1b5b6..bcb357e 100644 --- a/arch/arm/mach-omap2/hwspinlock.c +++ b/arch/arm/mach-omap2/hwspinlock.c @@ -21,6 +21,7 @@ #include #include +#include "soc.h" #include "omap_hwmod.h" #include "omap_device.h"