From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hiroshi Doyu Subject: Re: [PATCH 1/4] ARM: tegra: Unify tegra{20,30,114}_init_early() Date: Fri, 8 Feb 2013 09:09:42 +0100 Message-ID: <20130208.100942.592982910310763762.hdoyu@nvidia.com> References: <1360308574-19658-1-git-send-email-hdoyu@nvidia.com><1360308574-19658-2-git-send-email-hdoyu@nvidia.com><20130208074720.GB21879@arwen.pp.htv.fi> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT Return-path: In-Reply-To: <20130208074720.GB21879-S8G//mZuvNWo5Im9Ml3/Zg@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: "balbi-l0cyMroinI0@public.gmane.org" Cc: "linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "arnd-r2nGTMty4D4@public.gmane.org" , "swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org" , "linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org" , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: linux-tegra@vger.kernel.org Hi Felipe, Felipe Balbi wrote @ Fri, 8 Feb 2013 08:47:20 +0100: > > +#if defined(CONFIG_ARCH_TEGRA_3x_SOC) > > how about using: > > #if IS_BUILTIN(CONFIG_ARCH_TEGRA_3x_SOC) > > instead ? Why is IS_BUILTIN() prefered? > > -void tegra20_hotplug_init(void); > > -void tegra30_hotplug_init(void); > > +void tegra20_hotplug_shutdown(void); > > +void tegra30_hotplug_shutdown(void); > > aren't these two called only by tegra_hotplug_init() now ? Yes > That means they don't need to be exposed. tegra{20,30}_hotplug_shutdown are defined in sleep-tegra{20,30}.S and used in hotplug.c So I think that the above are necessary here. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760007Ab3BHIKT (ORCPT ); Fri, 8 Feb 2013 03:10:19 -0500 Received: from hqemgate03.nvidia.com ([216.228.121.140]:3220 "EHLO hqemgate03.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758082Ab3BHIKQ convert rfc822-to-8bit (ORCPT ); Fri, 8 Feb 2013 03:10:16 -0500 X-PGP-Universal: processed; by hqnvupgp05.nvidia.com on Fri, 08 Feb 2013 00:10:08 -0800 From: Hiroshi Doyu To: "balbi@ti.com" CC: "linux-tegra@vger.kernel.org" , "arnd@arndb.de" , "swarren@wwwdotorg.org" , "linux@arm.linux.org.uk" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Date: Fri, 8 Feb 2013 09:09:42 +0100 Subject: Re: [PATCH 1/4] ARM: tegra: Unify tegra{20,30,114}_init_early() Thread-Topic: [PATCH 1/4] ARM: tegra: Unify tegra{20,30,114}_init_early() Thread-Index: Ac4F06qKQ6zWVLrkQk679nufXV/uAQ== Message-ID: <20130208.100942.592982910310763762.hdoyu@nvidia.com> References: <1360308574-19658-1-git-send-email-hdoyu@nvidia.com><1360308574-19658-2-git-send-email-hdoyu@nvidia.com><20130208074720.GB21879@arwen.pp.htv.fi> In-Reply-To: <20130208074720.GB21879@arwen.pp.htv.fi> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-nvconfidentiality: public acceptlanguage: en-US Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Felipe, Felipe Balbi wrote @ Fri, 8 Feb 2013 08:47:20 +0100: > > +#if defined(CONFIG_ARCH_TEGRA_3x_SOC) > > how about using: > > #if IS_BUILTIN(CONFIG_ARCH_TEGRA_3x_SOC) > > instead ? Why is IS_BUILTIN() prefered? > > -void tegra20_hotplug_init(void); > > -void tegra30_hotplug_init(void); > > +void tegra20_hotplug_shutdown(void); > > +void tegra30_hotplug_shutdown(void); > > aren't these two called only by tegra_hotplug_init() now ? Yes > That means they don't need to be exposed. tegra{20,30}_hotplug_shutdown are defined in sleep-tegra{20,30}.S and used in hotplug.c So I think that the above are necessary here. From mboxrd@z Thu Jan 1 00:00:00 1970 From: hdoyu@nvidia.com (Hiroshi Doyu) Date: Fri, 8 Feb 2013 09:09:42 +0100 Subject: [PATCH 1/4] ARM: tegra: Unify tegra{20,30,114}_init_early() In-Reply-To: <20130208074720.GB21879@arwen.pp.htv.fi> References: <1360308574-19658-1-git-send-email-hdoyu@nvidia.com><1360308574-19658-2-git-send-email-hdoyu@nvidia.com><20130208074720.GB21879@arwen.pp.htv.fi> Message-ID: <20130208.100942.592982910310763762.hdoyu@nvidia.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Felipe, Felipe Balbi wrote @ Fri, 8 Feb 2013 08:47:20 +0100: > > +#if defined(CONFIG_ARCH_TEGRA_3x_SOC) > > how about using: > > #if IS_BUILTIN(CONFIG_ARCH_TEGRA_3x_SOC) > > instead ? Why is IS_BUILTIN() prefered? > > -void tegra20_hotplug_init(void); > > -void tegra30_hotplug_init(void); > > +void tegra20_hotplug_shutdown(void); > > +void tegra30_hotplug_shutdown(void); > > aren't these two called only by tegra_hotplug_init() now ? Yes > That means they don't need to be exposed. tegra{20,30}_hotplug_shutdown are defined in sleep-tegra{20,30}.S and used in hotplug.c So I think that the above are necessary here.