From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/2] ARM: uncompress debug support for multiplatform build
Date: Fri, 8 Feb 2013 12:59:39 +0000 [thread overview]
Message-ID: <20130208125939.GQ17833@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20130207050434.GA7697@S2101-09.ap.freescale.net>
On Thu, Feb 07, 2013 at 01:04:36PM +0800, Shawn Guo wrote:
> === omap ===
>
> AS arch/arm/boot/compressed/debug.o
> LD arch/arm/boot/compressed/vmlinux
> `.data' referenced in section `.text' of arch/arm/boot/compressed/debug.o: defined in discarded section `.data' of arch/arm/boot/compressed/debug.o
> make[3]: *** [arch/arm/boot/compressed/vmlinux] Error 1
>
> The following change moving the variables out of stack section seems
> fixing the failure, but I'm not quite sure if it works.
>
> 8<---
> diff --git a/arch/arm/mach-omap2/include/mach/debug-macro.S b/arch/arm/mach-omap2/include/mach/debug
> index cfaed13..7b2877e 100644
> --- a/arch/arm/mach-omap2/include/mach/debug-macro.S
> +++ b/arch/arm/mach-omap2/include/mach/debug-macro.S
> @@ -17,11 +17,9 @@
>
> #define UART_OFFSET(addr) ((addr) & 0x00ffffff)
>
> - .pushsection .data
> omap_uart_phys: .word 0
> omap_uart_virt: .word 0
> omap_uart_lsr: .word 0
> - .popsection
No, this won't work, because now these variables are located in the text
section which may not be writable. I don't know what the answer is to
this, but as things stand it's not something that can go into v3.8 until
these problems are addressed (because if it does it _will_ cause
regressions.)
We're basically on the last day of -rc6, so I think it's all too late to
try and get this sorted for this merge window.
next prev parent reply other threads:[~2013-02-08 12:59 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-17 15:21 [PATCH 0/2] Uncompress debug for multiplatform Shawn Guo
2013-01-17 15:21 ` [PATCH 1/2] ARM: use Kconfig to select uncompress.h Shawn Guo
2013-01-17 16:00 ` Arnd Bergmann
2013-01-17 15:21 ` [PATCH 2/2] ARM: use DEBUG_LL infrastructural for multiplatform uncompress debug Shawn Guo
2013-01-17 15:33 ` Shawn Guo
2013-01-17 16:25 ` Arnd Bergmann
2013-01-18 2:49 ` Shawn Guo
2013-01-18 2:45 ` [PATCH v2 2/2] ARM: uncompress debug support for multiplatform build Shawn Guo
2013-01-18 8:47 ` Arnd Bergmann
2013-01-18 10:42 ` Russell King - ARM Linux
2013-01-18 11:15 ` Shawn Guo
2013-01-18 18:03 ` Olof Johansson
2013-02-04 16:01 ` Russell King - ARM Linux
2013-02-06 9:32 ` Russell King - ARM Linux
2013-02-06 19:04 ` Stephen Warren
2013-02-07 5:04 ` Shawn Guo
2013-02-07 16:36 ` Stephen Warren
2013-02-08 12:59 ` Russell King - ARM Linux [this message]
2013-02-08 11:44 ` [PATCH v3 " Shawn Guo
2013-02-08 12:27 ` Russell King - ARM Linux
2013-02-08 12:45 ` Shawn Guo
[not found] ` <20130128141947.GA11626@S2101-09.ap.freescale.net>
2013-01-28 14:22 ` [PATCH 0/2] Uncompress debug for multiplatform Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130208125939.GQ17833@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.