From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff King Subject: Re: [PATCH 4/4] git-remote-mediawiki: use Git's Makefile to build the script Date: Fri, 8 Feb 2013 13:15:56 -0500 Message-ID: <20130208181556.GA387@sigill.intra.peff.net> References: <1360174292-14793-1-git-send-email-Matthieu.Moy@imag.fr> <1360174292-14793-5-git-send-email-Matthieu.Moy@imag.fr> <7vhaln7wkg.fsf@alter.siamese.dyndns.org> <20130208042800.GB4157@sigill.intra.peff.net> <20130208174350.GA28266@sigill.intra.peff.net> <7v62223c8s.fsf@alter.siamese.dyndns.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Cc: Matthieu Moy , git@vger.kernel.org To: Junio C Hamano X-From: git-owner@vger.kernel.org Fri Feb 08 19:16:31 2013 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1U3sUq-0006lq-M2 for gcvg-git-2@plane.gmane.org; Fri, 08 Feb 2013 19:16:25 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1946858Ab3BHSQB (ORCPT ); Fri, 8 Feb 2013 13:16:01 -0500 Received: from 75-15-5-89.uvs.iplsin.sbcglobal.net ([75.15.5.89]:42440 "EHLO peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1946728Ab3BHSQA (ORCPT ); Fri, 8 Feb 2013 13:16:00 -0500 Received: (qmail 31680 invoked by uid 107); 8 Feb 2013 18:17:25 -0000 Received: from sigill.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.7) (smtp-auth username relayok, mechanism cram-md5) by peff.net (qpsmtpd/0.84) with ESMTPA; Fri, 08 Feb 2013 13:17:25 -0500 Received: by sigill.intra.peff.net (sSMTP sendmail emulation); Fri, 08 Feb 2013 13:15:56 -0500 Content-Disposition: inline In-Reply-To: <7v62223c8s.fsf@alter.siamese.dyndns.org> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: On Fri, Feb 08, 2013 at 10:13:23AM -0800, Junio C Hamano wrote: > Jeff King writes: > > > On Fri, Feb 08, 2013 at 06:34:37PM +0100, Matthieu Moy wrote: > > > >> Jeff King writes: > >> > >> > That seems much cleaner to me. If done right, it could also let people > >> > put: > >> > > >> > CONTRIB_PERL += contrib/mw-to-git/git-remote-mediawiki > >> > >> Actually, you can already do this: > >> > >> SCRIPT_PERL += contrib/mw-to-git/git-remote-mediawiki.perl > >> > >> probably not by design, but it works! > > > > So putting: > > > > ROOT=contrib/mw-to-git > > git-remote-mediawiki: FORCE > > @make -C ../.. SCRIPT_PERL=$(ROOT)/$@.perl $(ROOT)/$@ > > > > in contrib/mw-to-git/Makefile would already work? Neat. > > That essentially is what [v2 2/2] does, no? Yes (this one was cc'd to me, but the others were not, so I read it in isolation). I think Matthieu's series is nicer than just that, though, because it handles the single-file case installation, too, which requires more support from the parent Makefile. -Peff