From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH v2 0/8] ARM: omap2: GPMC cleanup Date: Tue, 12 Feb 2013 09:12:53 -0800 Message-ID: <20130212171253.GI4801@atomide.com> References: <1360682305-20935-1-git-send-email-ezequiel.garcia@free-electrons.com> <511A6EA1.80301@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mho-04-ewr.mailhop.org ([204.13.248.74]:11030 "EHLO mho-02-ewr.mailhop.org" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S933376Ab3BLRM6 (ORCPT ); Tue, 12 Feb 2013 12:12:58 -0500 Content-Disposition: inline In-Reply-To: <511A6EA1.80301@ti.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Jon Hunter Cc: Ezequiel Garcia , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Felipe Balbi , Afzal Mohammed * Jon Hunter [130212 08:36]: > > On 02/12/2013 09:18 AM, Ezequiel Garcia wrote: > > This patchset is v2 of the small cleanup consisting in: > > * mark some functions as 'static' when appropriate > > * remove an unused function from gpmc.c > > * improve error messages when a CS request fails > > * migrate to dev_err and dev_warn > > > > Changelog from v1: > > * fix gpmc_cs_reserved to return a boolean instead > > of an integer error code > > * add a new patch to the patchset cleaning redundant checks > > > > It has been tested on a IGEP v2 board with OneNAND, > > which means the gpmc-nand patch is tested by compilation only. > > > > Altough these patchset is almost trivial, > > any feedback or testing is more than welcome. > > > > Ezequiel Garcia (8): > > ARM: omap2: gpmc: Mark local scoped functions static > > ARM: omap2: gpmc: Remove unused gpmc_round_ns_to_ticks() function > > ARM: omap2: gpmc: Fix gpmc_cs_reserved() return value > > ARM: omap2: gpmc-nand: Print something useful on CS request failure > > ARM: omap2: gpmc-onenand: Print something useful on CS request failure > > ARM: omap2: gpmc-onenand: Replace pr_err() with dev_err() > > ARM: omap2: gpmc-onenand: Replace printk KERN_ERR with dev_warn() > > ARM: omap2: gpmc: Remove redundant chip select out of range check > > > > arch/arm/mach-omap2/gpmc-nand.c | 3 ++- > > arch/arm/mach-omap2/gpmc-onenand.c | 8 +++++--- > > arch/arm/mach-omap2/gpmc.c | 27 ++++++--------------------- > > arch/arm/mach-omap2/gpmc.h | 7 ------- > > 4 files changed, 13 insertions(+), 32 deletions(-) > > Looks good to me. I noticed that for some patches there is no changelog > and I understand that that is because they are some what trivial > clean-ups and the subject explains the patch. However, typically it is > good to have a changelog in the patch no matter how trivial it is. Tony > may ask you to add a changelog. Otherwise ... > > Reviewed-by: Jon Hunter Yes please add a changelog. Tony From mboxrd@z Thu Jan 1 00:00:00 1970 From: tony@atomide.com (Tony Lindgren) Date: Tue, 12 Feb 2013 09:12:53 -0800 Subject: [PATCH v2 0/8] ARM: omap2: GPMC cleanup In-Reply-To: <511A6EA1.80301@ti.com> References: <1360682305-20935-1-git-send-email-ezequiel.garcia@free-electrons.com> <511A6EA1.80301@ti.com> Message-ID: <20130212171253.GI4801@atomide.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org * Jon Hunter [130212 08:36]: > > On 02/12/2013 09:18 AM, Ezequiel Garcia wrote: > > This patchset is v2 of the small cleanup consisting in: > > * mark some functions as 'static' when appropriate > > * remove an unused function from gpmc.c > > * improve error messages when a CS request fails > > * migrate to dev_err and dev_warn > > > > Changelog from v1: > > * fix gpmc_cs_reserved to return a boolean instead > > of an integer error code > > * add a new patch to the patchset cleaning redundant checks > > > > It has been tested on a IGEP v2 board with OneNAND, > > which means the gpmc-nand patch is tested by compilation only. > > > > Altough these patchset is almost trivial, > > any feedback or testing is more than welcome. > > > > Ezequiel Garcia (8): > > ARM: omap2: gpmc: Mark local scoped functions static > > ARM: omap2: gpmc: Remove unused gpmc_round_ns_to_ticks() function > > ARM: omap2: gpmc: Fix gpmc_cs_reserved() return value > > ARM: omap2: gpmc-nand: Print something useful on CS request failure > > ARM: omap2: gpmc-onenand: Print something useful on CS request failure > > ARM: omap2: gpmc-onenand: Replace pr_err() with dev_err() > > ARM: omap2: gpmc-onenand: Replace printk KERN_ERR with dev_warn() > > ARM: omap2: gpmc: Remove redundant chip select out of range check > > > > arch/arm/mach-omap2/gpmc-nand.c | 3 ++- > > arch/arm/mach-omap2/gpmc-onenand.c | 8 +++++--- > > arch/arm/mach-omap2/gpmc.c | 27 ++++++--------------------- > > arch/arm/mach-omap2/gpmc.h | 7 ------- > > 4 files changed, 13 insertions(+), 32 deletions(-) > > Looks good to me. I noticed that for some patches there is no changelog > and I understand that that is because they are some what trivial > clean-ups and the subject explains the patch. However, typically it is > good to have a changelog in the patch no matter how trivial it is. Tony > may ask you to add a changelog. Otherwise ... > > Reviewed-by: Jon Hunter Yes please add a changelog. Tony