From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933564Ab3BLRfK (ORCPT ); Tue, 12 Feb 2013 12:35:10 -0500 Received: from smtp.snhosting.dk ([87.238.248.203]:34998 "EHLO smtp.domainteam.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933329Ab3BLRfI (ORCPT ); Tue, 12 Feb 2013 12:35:08 -0500 Date: Tue, 12 Feb 2013 18:35:06 +0100 From: Sam Ravnborg To: Len Brown Cc: Stephen Rothwell , Len Brown , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, "David S. Miller" , sparclinux@vger.kernel.org Subject: Re: linux-next: build failure after merge of the final tree (acpi tree related) Message-ID: <20130212173505.GA2155@merkur.ravnborg.org> References: <20130211183409.7519b73ca320baeac5ec886f@canb.auug.org.au> <51197D8B.6010407@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <51197D8B.6010407@kernel.org> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > Signed-off-by: Stephen Rothwell > > --- > > arch/sparc/include/asm/processor.h | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/arch/sparc/include/asm/processor.h b/arch/sparc/include/asm/processor.h > > index 34baa35..622cfa5 100644 > > --- a/arch/sparc/include/asm/processor.h > > +++ b/arch/sparc/include/asm/processor.h > > @@ -7,6 +7,8 @@ > > #endif > > > > #define nop() __asm__ __volatile__ ("nop") > > +#ifndef __ASSEMBLY__ > > extern void (*sparc_idle)(void); > > +#endif > > > > #endif > > > > Thank you Stephen! > > The last time I compiled a sparc kernel was in 1993:-) > > I've added your fix and Dave's Ack to this patch, > and updated it in my next branch. Hi Len. Can you please move the definition of sparc_idle to processor_32.h It is sparc32 specific - and then we do not need the __ASSEMBLY__ guards as the sparc32 variant are not used from assembler. Do you btw. have any hints how I can convert to the cpu_idle thing you hinted? Sam From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sam Ravnborg Date: Tue, 12 Feb 2013 17:35:06 +0000 Subject: Re: linux-next: build failure after merge of the final tree (acpi tree related) Message-Id: <20130212173505.GA2155@merkur.ravnborg.org> List-Id: References: <20130211183409.7519b73ca320baeac5ec886f@canb.auug.org.au> <51197D8B.6010407@kernel.org> In-Reply-To: <51197D8B.6010407@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Len Brown Cc: Stephen Rothwell , Len Brown , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, "David S. Miller" , sparclinux@vger.kernel.org > > Signed-off-by: Stephen Rothwell > > --- > > arch/sparc/include/asm/processor.h | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/arch/sparc/include/asm/processor.h b/arch/sparc/include/asm/processor.h > > index 34baa35..622cfa5 100644 > > --- a/arch/sparc/include/asm/processor.h > > +++ b/arch/sparc/include/asm/processor.h > > @@ -7,6 +7,8 @@ > > #endif > > > > #define nop() __asm__ __volatile__ ("nop") > > +#ifndef __ASSEMBLY__ > > extern void (*sparc_idle)(void); > > +#endif > > > > #endif > > > > Thank you Stephen! > > The last time I compiled a sparc kernel was in 1993:-) > > I've added your fix and Dave's Ack to this patch, > and updated it in my next branch. Hi Len. Can you please move the definition of sparc_idle to processor_32.h It is sparc32 specific - and then we do not need the __ASSEMBLY__ guards as the sparc32 variant are not used from assembler. Do you btw. have any hints how I can convert to the cpu_idle thing you hinted? Sam