From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933675Ab3BLSB4 (ORCPT ); Tue, 12 Feb 2013 13:01:56 -0500 Received: from moutng.kundenserver.de ([212.227.17.9]:61798 "EHLO moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933589Ab3BLSBy (ORCPT ); Tue, 12 Feb 2013 13:01:54 -0500 From: Arnd Bergmann To: Thomas Petazzoni Subject: Re: [PATCH 05/32] lib: devres: don't enclose pcim_*() functions in CONFIG_HAS_IOPORT Date: Tue, 12 Feb 2013 18:00:48 +0000 User-Agent: KMail/1.12.2 (Linux/3.8.0-5-generic; KDE/4.3.2; x86_64; ; ) Cc: Bjorn Helgaas , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Lior Amsalem , Andrew Lunn , "Russell King - ARM Linux" , Jason Cooper , Stephen Warren , Thierry Reding , "Eran Ben-Avi" , Nadav Haklai , Maen Suleiman , Shadi Ammouri , Gregory Clement , Jason Gunthorpe , Tawfik Bayouk , Paul Gortmaker , Jesse Barnes , Yinghai Lu , linux-kernel@vger.kernel.org References: <1360686546-24277-1-git-send-email-thomas.petazzoni@free-electrons.com> <1360686546-24277-6-git-send-email-thomas.petazzoni@free-electrons.com> In-Reply-To: <1360686546-24277-6-git-send-email-thomas.petazzoni@free-electrons.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201302121800.48723.arnd@arndb.de> X-Provags-ID: V02:K0:OMtpggWRMqS6dJ/qSz/b7t7iUgCMnpKVCUVu2wRI1g8 RkgjTvxJzqrML76HDT6pcMQPnfM+7u8UU5jolfhHqLgfWpI/UX CMhGKrIic1XZwEPYnUeoDEWgpL9SQwFPrmrcCaZ3Rqb0tKivXO NAKHU6dXOmd9ZbZB9fwraZnyz2a/rf15AK+jf3aG60NB7PVFZN SYx78q2OOlNfNRlxT/E6dYdteC5WoUZggpjSv6m1iSNVGHa4cT Qb/iOrR6hOAAVoDaw21pzTPldQe+oPprf+o82SeLZ9iSv3Cy3g OcmBlhgnQrTeNNUFHS47j0KXmk3CLrWTgyGAAnfnMXcGHpGYWo R5Hw3ef5oAXU7KhZAoz8= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday 12 February 2013, Thomas Petazzoni wrote: > The pcim_*() functions are used by the libata-sff subsystem, and this > subsystem is used for many SATA drivers on ARM platforms that do not > necessarily have I/O ports. > > Signed-off-by: Thomas Petazzoni > Cc: Paul Gortmaker > Cc: Jesse Barnes > Cc: Yinghai Lu > Cc: linux-kernel@vger.kernel.org Sorry, but this patch is still incorrect. Any driver that requires a linear mapping of I/O ports to __iomem pointers must depend CONFIG_HAS_IOPORT with the current definition of that symbol (as mentioned before, we should really rename that to CONFIG_HAS_IOPORT_MAP). Having these functions not defined is a compile time check that is necessary to ensure that all drivers have the correct annotation. If a platform has no support for I/O ports at all, it should probably not set CONFIG_NO_IOPORT at this point. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 From: arnd@arndb.de (Arnd Bergmann) Date: Tue, 12 Feb 2013 18:00:48 +0000 Subject: [PATCH 05/32] lib: devres: don't enclose pcim_*() functions in CONFIG_HAS_IOPORT In-Reply-To: <1360686546-24277-6-git-send-email-thomas.petazzoni@free-electrons.com> References: <1360686546-24277-1-git-send-email-thomas.petazzoni@free-electrons.com> <1360686546-24277-6-git-send-email-thomas.petazzoni@free-electrons.com> Message-ID: <201302121800.48723.arnd@arndb.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tuesday 12 February 2013, Thomas Petazzoni wrote: > The pcim_*() functions are used by the libata-sff subsystem, and this > subsystem is used for many SATA drivers on ARM platforms that do not > necessarily have I/O ports. > > Signed-off-by: Thomas Petazzoni > Cc: Paul Gortmaker > Cc: Jesse Barnes > Cc: Yinghai Lu > Cc: linux-kernel at vger.kernel.org Sorry, but this patch is still incorrect. Any driver that requires a linear mapping of I/O ports to __iomem pointers must depend CONFIG_HAS_IOPORT with the current definition of that symbol (as mentioned before, we should really rename that to CONFIG_HAS_IOPORT_MAP). Having these functions not defined is a compile time check that is necessary to ensure that all drivers have the correct annotation. If a platform has no support for I/O ports at all, it should probably not set CONFIG_NO_IOPORT at this point. Arnd