From: Hans-Christian Egtvedt <egtvedt@samfundet.no>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Haavard Skinnemoen <hskinnemoen@gmail.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] avr32: atmel_default_console_device depends on CONFIG_SERIAL_ATMEL
Date: Wed, 13 Feb 2013 00:49:21 +0100 [thread overview]
Message-ID: <20130212234921.GA11388@samfundet.no> (raw)
In-Reply-To: <1360679255-11799-1-git-send-email-geert@linux-m68k.org>
Around Tue 12 Feb 2013 15:27:35 +0100 or thereabout, Geert Uytterhoeven wrote:
> allnoconfig:
>
> arch/avr32/mach-at32ap/built-in.o: In function `at32_select_gpio':
> (.init.text+0x548): undefined reference to `atmel_default_console_device'
Indeed, I guess building without serial support has never been done.
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
>
Acked-by: Hans-Christian Egtvedt <egtvedt@samfundet.no>
> ---
> arch/avr32/mach-at32ap/at32ap700x.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/arch/avr32/mach-at32ap/at32ap700x.c b/arch/avr32/mach-at32ap/at32ap700x.c
> index b323d8d..a2fe61b 100644
> --- a/arch/avr32/mach-at32ap/at32ap700x.c
> +++ b/arch/avr32/mach-at32ap/at32ap700x.c
> @@ -1060,7 +1060,9 @@ struct platform_device *__init at32_add_device_usart(unsigned int id)
>
> void __init at32_setup_serial_console(unsigned int usart_id)
> {
> +#ifdef CONFIG_SERIAL_ATMEL
> atmel_default_console_device = at32_usarts[usart_id];
> +#endif
> }
>
> /* --------------------------------------------------------------------
--
mvh
Hans-Christian Egtvedt
prev parent reply other threads:[~2013-02-13 0:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-12 14:27 [PATCH] avr32: atmel_default_console_device depends on CONFIG_SERIAL_ATMEL Geert Uytterhoeven
2013-02-12 23:49 ` Hans-Christian Egtvedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130212234921.GA11388@samfundet.no \
--to=egtvedt@samfundet.no \
--cc=geert@linux-m68k.org \
--cc=hskinnemoen@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.