From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ben Widawsky <ben@bwidawsk.net>
Subject: Re: [PATCH 1/3] drm/i915: remove bogus mutex_unlock
	from error-path
Date: Tue, 12 Feb 2013 21:27:13 -0800
Message-ID: <20130213052713.GA12888@lundgren.kumite>
References: <1360679765-9039-1-git-send-email-daniel.vetter@ffwll.ch>
	<1360679765-9039-2-git-send-email-daniel.vetter@ffwll.ch>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from shiva.chad-versace.us (209-20-75-48.static.cloud-ips.com
	[209.20.75.48])
	by gabe.freedesktop.org (Postfix) with ESMTP id 1A1B8E5CBC
	for <intel-gfx@lists.freedesktop.org>;
	Tue, 12 Feb 2013 21:25:39 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <1360679765-9039-2-git-send-email-daniel.vetter@ffwll.ch>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

On Tue, Feb 12, 2013 at 03:36:03PM +0100, Daniel Vetter wrote:
> This has been lost in the locking rework for intel_alloc_context_page:
> 
> commit 2c34b850ee1e9f86b41706149d0954eee58757a3
> Author: Ben Widawsky <ben@bwidawsk.net>
> Date:   Sat Mar 19 18:14:26 2011 -0700
> 
>     drm/i915: fix ilk rc6 teardown locking
> 
> Cc: Ben Widawsky <ben@bwidawsk.net>
> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>

I'm confused about how it got lost.
Reviewed-by: Ben Widawsky <ben@bwidawsk.net>

> ---
>  drivers/gpu/drm/i915/intel_pm.c |    1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> index 3280cff..7658c39 100644
> --- a/drivers/gpu/drm/i915/intel_pm.c
> +++ b/drivers/gpu/drm/i915/intel_pm.c
> @@ -2286,7 +2286,6 @@ err_unpin:
>  	i915_gem_object_unpin(ctx);
>  err_unref:
>  	drm_gem_object_unreference(&ctx->base);
> -	mutex_unlock(&dev->struct_mutex);
>  	return NULL;
>  }
>  
> -- 
> 1.7.10.4
> 

-- 
Ben Widawsky, Intel Open Source Technology Center