All of lore.kernel.org
 help / color / mirror / Atom feed
From: Grant Likely <grant.likely@secretlab.ca>
To: Stephen Warren <swarren@wwwdotorg.org>
Cc: devicetree-discuss@lists.ozlabs.org,
	linux-kernel@vger.kernel.org, Rob Herring <robherring2@gmail.com>
Subject: Re: [PATCH] of: Fix locking when calling of_get_next_available_child()
Date: Wed, 13 Feb 2013 10:08:51 +0000	[thread overview]
Message-ID: <20130213100851.7620A3E23F1@localhost> (raw)
In-Reply-To: <51197E36.8080704@wwwdotorg.org>

On Mon, 11 Feb 2013 16:26:46 -0700, Stephen Warren <swarren@wwwdotorg.org> wrote:
> On 02/11/2013 03:19 PM, Grant Likely wrote:
> > of_get_next_available_child() obtains the devtree_lock and then calls
> > of_device_is_available() which also attempts to claim the lock. This is
> > obviously incorrect and causes a deadlock on boot. Fix issue by adding
> > an variant of of_device_is_available() which doesn't obtain the lock.
> 
> This patch forgets to update __of_device_is_available() to call
> __of_get_property() rather than of_get_property() and hence doesn't
> actually solve the problem.
> 
> You might want to make __of_device_is_available() static too.

Okay, I've dropped this patch and replaced it with your version since
you're actually doing better testing that I it would appear. I had to
respin my tree anyway because I messed up a merge of Rob's branch. :-(
Sorry for the noise.

New version of the tree is pushed out.

g.


      parent reply	other threads:[~2013-02-13 10:08 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-11 22:19 [PATCH] of: Fix locking when calling of_get_next_available_child() Grant Likely
2013-02-11 22:19 ` Grant Likely
2013-02-11 22:27 ` Rob Herring
2013-02-11 22:30   ` Grant Likely
2013-02-11 23:26 ` Stephen Warren
2013-02-12 15:20   ` Thierry Reding
2013-02-13 10:08   ` Grant Likely [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130213100851.7620A3E23F1@localhost \
    --to=grant.likely@secretlab.ca \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robherring2@gmail.com \
    --cc=swarren@wwwdotorg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.