All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: George Spelvin <linux@horizon.com>
Cc: linux-serial@vger.kernel.org, peter@hurleysoftware.com,
	linux-kernel@vger.kernel.org, giometti@linux.it
Subject: Re: [PATCH v2 5/9] pps: Move timestamp read into PPS code proper
Date: Wed, 13 Feb 2013 10:16:28 -0800	[thread overview]
Message-ID: <20130213181628.GA17367@kroah.com> (raw)
In-Reply-To: <31e24f360b1715c262c05d6708353e292640b3a8.1360677367.git.linux@horizon.com>

On Tue, Feb 12, 2013 at 02:00:43AM -0500, George Spelvin wrote:
> The PPS (Pulse-Per-Second) line discipline has developed a number of
> unhealthy attachments to core tty data and functions, ultimately leading
> to its breakage.
> 
> The previous patches fixed the crashing.  This one reduces coupling further
> by eliminating the timestamp parameter from the dcd_change ldisc method.
> This reduces header file linkage and makes the extension more generic,
> and the timestamp read is delayed only slightly, from just before the
> ldisc->ops->dcd_change method call to just after.
> 
> Fix attendant build breakage in
>     drivers/tty/n_tty.c
>     drivers/tty/tty_buffer.c
>     drivers/staging/speakup/selection.c

I also had to fix up:
	drivers/staging/dgrp/dgrp_*.c

to get things to build properly.

thanks,

greg k-h

  reply	other threads:[~2013-02-13 18:16 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-12 13:56 [PATCH v2 0/9] 3.8-rc regression with pps-ldisc due to 70ece7a731 George Spelvin
2013-02-06 15:55 ` [PATCH v2 7/9] tty: Remove ancient hardpps() Peter Hurley
2013-02-08  6:50 ` [PATCH v2 9/9] tty/tty_ldisc.c: use test_and_clear_bit in tty_ldisc_close George Spelvin
2013-02-10  9:08 ` [PATCH v2 1/9] pps: Add pps_lookup_dev() function George Spelvin
2013-02-10  9:41 ` [PATCH v2 2/9] pps: Use pps_lookup_dev to reduce ldisc coupling George Spelvin
2013-02-10  9:43 ` [PATCH v2 4/9] pps: Don't crash the machine when exiting will do George Spelvin
2013-02-10  9:44 ` [PATCH v2 6/9] pps: Additional cleanups in uart_handle_dcd_change George Spelvin
2013-02-12  7:00 ` [PATCH v2 5/9] pps: Move timestamp read into PPS code proper George Spelvin
2013-02-13 18:16   ` Greg KH [this message]
2013-02-12  7:02 ` [PATCH v2 8/9] pps: Use a single cdev George Spelvin
2013-02-13 18:20   ` Greg KH
2013-02-13 18:35     ` George Spelvin
2013-02-13 18:47       ` Greg KH
2013-02-21  1:35   ` Peter Hurley
2013-02-12  7:27 ` [PATCH v2 3/9] pps: Fix a use-after free bug when unregistering a source George Spelvin
2013-02-13 16:45 ` [PATCH v2 0/9] 3.8-rc regression with pps-ldisc due to 70ece7a731 Greg KH
2013-02-13 17:11   ` Rodolfo Giometti
2013-02-13 17:11     ` Rodolfo Giometti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130213181628.GA17367@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=giometti@linux.it \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=linux@horizon.com \
    --cc=peter@hurleysoftware.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.