All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Jones <davej@redhat.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Hugh Dickins <hughd@google.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Debugging Thinkpad T430s occasional suspend failure.
Date: Wed, 13 Feb 2013 15:53:13 -0500	[thread overview]
Message-ID: <20130213205313.GA31374@redhat.com> (raw)
In-Reply-To: <CA+55aFzmEDriX26Z7oJZg9yssFdCAaYwu6krmrwqfj2TBsxA4w@mail.gmail.com>

On Wed, Feb 13, 2013 at 11:56:25AM -0800, Linus Torvalds wrote:

 > Note that there is only ever one "bad" commit - since all the commits
 > you test while bisecting are by definition reachable from the previous
 > bad one and both contain the bug, picking a bad commit makes all other
 > previous bad commits uninteresting. So you just need to look at the
 > last bad commit, not the whole set of bad commits. So when re-doing
 > the bisect, and if you trust that your bad kernels really were bad and
 > had the *right* badness, you can just start with "git bisect bad
 > <last-bad-commit>"
 > 
 > (good commits, on the other hand, are independent of each other: "not
 > containing the bug" is not some kind of exclusivity test, so finding
 > one good kernel doesn't make the information about other good kernels
 > irrelevant)

I've tried working my way back up the bisect and then retesting some
of those 'good' branches, but every time I feel like I'm getting somewhere,
I get another result that makes no sense.

The latest for example ends like this..

# bad: [ddffeb8c4d0331609ef2581d84de4d763607bd37] Linux 3.7-rc1
git bisect bad ddffeb8c4d0331609ef2581d84de4d763607bd37
# good: [a0d271cbfed1dd50278c6b06bead3d00ba0a88f9] Linux 3.6
git bisect good a0d271cbfed1dd50278c6b06bead3d00ba0a88f9
# good: [24d7b40a60cf19008334bcbcbd98da374d4d9c64] ARM: OMAP2+: PM: MPU DVFS: use generic CPU device for MPU-SS
git bisect good 24d7b40a60cf19008334bcbcbd98da374d4d9c64
# good: [21c8715f0a1f4df8bfa2bd6f3915e5e33c1c2e6e] ARM: integrator: use __iomem pointers for MMIO, part 2
git bisect good 21c8715f0a1f4df8bfa2bd6f3915e5e33c1c2e6e
# good: [23d5385f382a7c7d8b6bf19b0c2cfb3acbb12d31] Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/sparc
git bisect good 23d5385f382a7c7d8b6bf19b0c2cfb3acbb12d31
# good: [35e9a274fdc9c8feb763e4970a32d7089f51393c] Merge branch 'kconfig' of git://git.kernel.org/pub/scm/linux/kernel/git/mmarek/kbuild
git bisect good 35e9a274fdc9c8feb763e4970a32d7089f51393c
# bad: [e225ca27057e70e7cbb14ae4c1e5f758973af645] Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/sparc
git bisect bad e225ca27057e70e7cbb14ae4c1e5f758973af645
# good: [4f1cd91497774488ed16119ec3f54b3daf1561de] Merge branch 'v4l_for_linus' of git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-media
git bisect good 4f1cd91497774488ed16119ec3f54b3daf1561de
# bad: [4e21fc138bfd7fe625ff5dc81541399aaf9d429b] Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/signal
git bisect bad 4e21fc138bfd7fe625ff5dc81541399aaf9d429b
# bad: [ccff9b1db693062b0a9c9070f4304deb47ef215c] Merge tag 'stable/for-linus-3.7-rc0-tag' of git://git.kernel.org/pub/scm/linux/kernel/git/konrad/xen
git bisect bad ccff9b1db693062b0a9c9070f4304deb47ef215c
# good: [5b3900cd409466c0070b234d941650685ad0c791] timekeeping: Cast raw_interval to u64 to avoid shift overflow
git bisect good 5b3900cd409466c0070b234d941650685ad0c791
# bad: [0588f1f934791b79d0a1e9b327be9b6eb361d2b8] Merge branch 'sched-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
git bisect bad 0588f1f934791b79d0a1e9b327be9b6eb361d2b8
# bad: [9d55ab71b735621a63c8923ba934d87879847cef] Merge branch 'core-rcu-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
git bisect bad 9d55ab71b735621a63c8923ba934d87879847cef
# bad: [d677124b1fc3b2706a13e92f1b329f1ac77e5f20] rcu: Advise most users not to enable RCU user mode
git bisect bad d677124b1fc3b2706a13e92f1b329f1ac77e5f20
# bad: [a4fbe35a124526e6759be07bd9c7ea796ba1e00d] rcu: Grace-period initialization excludes only RCU notifier
git bisect bad a4fbe35a124526e6759be07bd9c7ea796ba1e00d

Which points out something in tree-rcu.  Which I don't even have compiled in,
because I have CONFIG_PREEMPT set.

I'll keep trying some of the earlier good branches in case I missed something.

	Dave


  reply	other threads:[~2013-02-13 20:53 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-12 19:39 Debugging Thinkpad T430s occasional suspend failure Dave Jones
2013-02-12 20:13 ` Linus Torvalds
2013-02-13  0:26 ` Hugh Dickins
2013-02-13  0:40   ` Dave Jones
2013-02-13  0:56     ` Hugh Dickins
2013-02-13  4:16       ` Dave Jones
2013-02-13  5:37         ` Hugh Dickins
2013-02-13 19:34           ` Dave Jones
2013-02-13 19:56             ` Linus Torvalds
2013-02-13 20:53               ` Dave Jones [this message]
2013-02-16 20:54                 ` Paul E. McKenney
2013-02-15  1:15               ` Dave Jones
2013-02-15  2:09                 ` Linus Torvalds
2013-02-15 15:50                   ` Ingo Molnar
2013-02-15 22:33                     ` Dave Jones
2013-02-15 17:44                   ` Paul E. McKenney
2013-02-15 18:34                     ` Linus Torvalds
2013-02-15 18:35                       ` Linus Torvalds
2013-02-15 18:50                         ` Linus Torvalds
2013-02-16 19:25                           ` Paul E. McKenney
2013-02-16 19:46                             ` Linus Torvalds
2013-02-16 21:07                               ` Paul E. McKenney
2013-02-16 21:53                               ` H. Peter Anvin
2013-02-17 22:49                               ` H. Peter Anvin
2013-02-18  8:41                                 ` Ingo Molnar
2013-02-19  8:50                                   ` Paul E. McKenney
2013-02-19  8:56                                     ` Ingo Molnar
2013-02-17 15:11                       ` Frederic Weisbecker
2013-02-17 17:32                         ` Linus Torvalds
2013-02-17 18:17                           ` Frederic Weisbecker
2013-02-17 20:58                           ` Frederic Weisbecker
2013-02-17 21:02                             ` Frederic Weisbecker
2013-02-18 15:53                               ` Frederic Weisbecker
2013-02-18 18:12                                 ` Linus Torvalds
2013-02-19 10:08                                   ` Frederic Weisbecker
2013-02-18 19:58                                 ` Thomas Gleixner
2013-02-19 10:38                                   ` Frederic Weisbecker
2013-02-19 10:44                                     ` Thomas Gleixner
2013-02-15  2:09                 ` Hugh Dickins
2013-02-15  2:15                   ` Linus Torvalds
2013-02-16 21:45                     ` Hugh Dickins
2013-02-16 23:02                       ` Linus Torvalds
2013-02-17  0:01                         ` Hugh Dickins
2013-02-17  2:21                           ` Hugh Dickins
2013-02-17 13:38                             ` Daniel Vetter
2013-02-17 14:54                               ` Daniel Vetter
2013-02-17 16:31                               ` Hugh Dickins
2013-02-17 17:28                                 ` Daniel Vetter
2013-02-17 17:28                                   ` Daniel Vetter
2013-02-13  2:17   ` Dave Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130213205313.GA31374@redhat.com \
    --to=davej@redhat.com \
    --cc=hughd@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.